-
Notifications
You must be signed in to change notification settings - Fork 421
Maintenance: Add header to LICENSE #1881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening your first issue here! We'll come back to you as soon as we can. |
Thanks a lot @meckhardt - Merging it within the next hour. |
@heitorlessa got feedback from Sonatype. They verified that the current license is proprietary and mentioned the metadata presented in PKG-INFO, when downloading https://files.pythonhosted.org/packages/1a/a0/e31457a2b66aa09fce91353141fcbde53cf1084328ec1c088aab215e76bd/aws_lambda_powertools-2.7.0.tar.gz.
I provided a fix, but better poetry / poetry-core must be fixed to generate the correct license metadata in PKG-INFO. |
Thanks for the heads up! Forgot for a second that Poetry generated that - I'll revert right after lunch |
Merged the last one. For attribution in the release notes, is it correct to assume you work for Sonatype @meckhardt? Thank you again!!! |
Released 2.7.1 - could you check one more time @meckhardt please? Thanks! |
@heitorlessa ❤️ License check from Nexus IQ runs through. Many thanks!
No, I'm freelancing and one of my customers uses Nexus IQ (Sonatype product). They scan packages for license issues and vulnurabilities and, well, there was a finding :-) |
@meckhardt we really appreciate raising this issue and your patience while we triple checked everything was kosher. We appreciate your support and your contribution! |
|
Summary
Missing header may lead to issues with license checkers, e.g. Nexus IQ.
Why is this needed?
Avoid false / positives when license is checked programmatically.
Which area does this relate to?
No response
Solution
Add the header
MIT No Attribution
as a first line.Acknowledgment
The text was updated successfully, but these errors were encountered: