Skip to content

Maintenance: Add header to LICENSE #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
e42sh opened this issue Feb 1, 2023 · 9 comments
Closed
2 tasks done

Maintenance: Add header to LICENSE #1881

e42sh opened this issue Feb 1, 2023 · 9 comments
Assignees
Labels
tech-debt Technical Debt tasks

Comments

@e42sh
Copy link

e42sh commented Feb 1, 2023

Summary

Missing header may lead to issues with license checkers, e.g. Nexus IQ.

Why is this needed?

Avoid false / positives when license is checked programmatically.

Which area does this relate to?

No response

Solution

Add the header MIT No Attribution as a first line.

Acknowledgment

@e42sh e42sh added internal Maintenance changes triage Pending triage from maintainers labels Feb 1, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 1, 2023

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@heitorlessa
Copy link
Contributor

Thanks a lot @meckhardt - Merging it within the next hour.

@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Feb 1, 2023
@e42sh
Copy link
Author

e42sh commented Feb 1, 2023

@heitorlessa got feedback from Sonatype. They verified that the current license is proprietary and mentioned the metadata presented in PKG-INFO, when downloading https://files.pythonhosted.org/packages/1a/a0/e31457a2b66aa09fce91353141fcbde53cf1084328ec1c088aab215e76bd/aws_lambda_powertools-2.7.0.tar.gz.

pic
See https://pypi.org/project/aws-lambda-powertools/

I provided a fix, but better poetry / poetry-core must be fixed to generate the correct license metadata in PKG-INFO.

@heitorlessa
Copy link
Contributor

Thanks for the heads up! Forgot for a second that Poetry generated that - I'll revert right after lunch

@heitorlessa
Copy link
Contributor

Merged the last one. For attribution in the release notes, is it correct to assume you work for Sonatype @meckhardt?

Thank you again!!!

@heitorlessa
Copy link
Contributor

heitorlessa commented Feb 1, 2023

Released 2.7.1 - could you check one more time @meckhardt please?

image

Thanks!

@e42sh
Copy link
Author

e42sh commented Feb 2, 2023

@heitorlessa ❤️

License check from Nexus IQ runs through. Many thanks!

For attribution in the release notes, is it correct to assume you work for Sonatype @meckhardt?

No, I'm freelancing and one of my customers uses Nexus IQ (Sonatype product). They scan packages for license issues and vulnurabilities and, well, there was a finding :-)

@rubenfonseca
Copy link
Contributor

@meckhardt we really appreciate raising this issue and your patience while we triple checked everything was kosher. We appreciate your support and your contribution!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical Debt tasks
Projects
None yet
Development

No branches or pull requests

3 participants