Skip to content

test(parser): Add missing test coverage and lint changes #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

michaelbrewer
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Make some methods static
  • Run code formatter
  • Some lint based changes
  • Add missing test cases

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Changes:
* Make some methods static
* Run code formatter
* Some lint based changes
* Add missing test cases
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2020

Codecov Report

Merging #188 into develop will increase coverage by 0.44%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
+ Coverage    98.76%   99.20%   +0.44%     
===========================================
  Files           64       64              
  Lines         2501     2503       +2     
  Branches       111      111              
===========================================
+ Hits          2470     2483      +13     
+ Misses          24       14      -10     
+ Partials         7        6       -1     
Impacted Files Coverage Δ
...owertools/utilities/advanced_parser/schemas/sqs.py 84.00% <33.33%> (ø)
...rtools/utilities/advanced_parser/envelopes/base.py 90.62% <100.00%> (+20.62%) ⬆️
...ls/utilities/advanced_parser/envelopes/dynamodb.py 100.00% <100.00%> (ø)
...ools/utilities/advanced_parser/schemas/dynamodb.py 100.00% <100.00%> (+6.06%) ⬆️
...ertools/utilities/advanced_parser/envelopes/sqs.py 100.00% <0.00%> (+17.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1ea1b...7d1abf0. Read the comment docs.

@michaelbrewer michaelbrewer changed the title tests(pydantic): Add missing coverage test(pydantic): Add missing coverage Oct 3, 2020
@michaelbrewer michaelbrewer changed the title test(pydantic): Add missing coverage test(pydantic): Add missing test coverage and lint changes Oct 3, 2020
@michaelbrewer
Copy link
Contributor Author

@heitorlessa - one thing I did pick up from the "schema" package was user specific examples. Should we move some of that into an examples or docs ?

@heitorlessa heitorlessa changed the title test(pydantic): Add missing test coverage and lint changes test(parser): Add missing test coverage and lint changes Oct 4, 2020
@heitorlessa
Copy link
Contributor

@heitorlessa - one thing I did pick up from the "schema" package was user specific examples. Should we move some of that into an examples or docs ?

They'll be in the docs. They're similar to the data classes, except they can be inherited and overridden so we can parse the entire payload + user defined models for autocompletion, etc.

Here's the list of other changes to be made before we launch 1.7.0 with it - Coverage and linting were some of them, so big thank you ;): #118 (comment)

@heitorlessa heitorlessa merged commit 42c84fc into aws-powertools:develop Oct 4, 2020
@michaelbrewer michaelbrewer deleted the tests-pydantic branch February 22, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants