-
Notifications
You must be signed in to change notification settings - Fork 421
feat(feature_flags): Add Time based feature flags actions #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feature_flags): Add Time based feature flags actions #1846
Conversation
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
|
1 similar comment
|
Codecov ReportBase: 97.59% // Head: 97.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1846 +/- ##
===========================================
- Coverage 97.59% 97.51% -0.08%
===========================================
Files 142 143 +1
Lines 6444 6567 +123
Branches 444 465 +21
===========================================
+ Hits 6289 6404 +115
- Misses 123 128 +5
- Partials 32 35 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
1 similar comment
|
The PR aws-powertools#1846 added a breaking change to RuleAction which not serializes the enum thus when used as an enum it breaks. Signed-off-by: royygael <[email protected]>
Issue number: #1554
This PR was created from this other PR: #1666. Click to read the entire interaction.
Summary
Use cases:
Changes
New actions: SCHEDULE_BETWEEN_TIME_RANGE, SCHEDULE_BETWEEN_DATETIME_RANGE, SCHEDULE_BETWEEN_DAYS_OF_WEEK
New keys: CURRENT_TIME, CURRENT_DATETIME, CURRENT_DAY_OF_WEEK
New values : a dict of START and END string values and a list of all weekdays. Also an optional TIMEZONE field supporting IANA Time zones. When not specified, we assume UTC.
Assumption: time is in 24 hours format, start time is always smaller than end time and it does not overlap a day.
User experience
As a customer, I'd like to flip a static flag value when evaluated between 11:11 and 23:59.
As a customer, I'd like to flip a static flag when evaluated between full datetime ranges 2022-10-05T12:15:00Z to 2022-10-10T12:15:00Z.
Selected days
As a customer, I'd like to flip a static flag when evaluated between Monday to Friday.
Day and time range combined
As a customer, I'd like to flip a static flag when evaluated Monday-Friday between 11:00 and 23:00 (UTC).
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
Tasks
_UTC
suffix in keys, and implement thetimezone
field on the value (usepython-dateutil
)