-
Notifications
You must be signed in to change notification settings - Fork 421
docs(homepage): auto-update Layer ARN on every release #1610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(homepage): auto-update Layer ARN on every release #1610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor issues (git add missing docs, and docs alias) - and one major to add comments on shell script as not everyone is a seasoned bash (and regex) wizardry like you ;D
Note: update the rest of the SAM sample code on docs/index.md |
Note: remove "Can't find our Lambda Layer for your preferred AWS region?" because we are now publishing in all regions. |
Docs looks excellent. Perhaps let's just increase md-grid (where the content is) to 90vw to give a bit more room, otherwise the layer per region table will look too tight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! added last suggestions on var names
Consider it approved after these last changes to ease maintenance. |
Co-authored-by: Heitor Lessa <[email protected]>
Issue number: #1549
Summary
This PR automates the publishing of the layer version in our documetation for every release.
This will reduce maintance overhead, and make the publishing of the new layer version faster.
Changes
User experience
After this change, the new layer version will be update don the documentation automatically, as soon as the Layer is created and published.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/index.md