Skip to content

docs: add troubleshooting section #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2020
Merged

docs: add troubleshooting section #151

merged 3 commits into from
Sep 1, 2020

Conversation

Nr18
Copy link

@Nr18 Nr18 commented Aug 30, 2020

Issue #, if available:

Description of changes:

Add a troubleshooting section in the CONTRIBUTING.md

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2020

Codecov Report

Merging #151 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #151   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          705       705           
  Branches        68        68           
=========================================
  Hits           705       705           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319c363...c6e7d06. Read the comment docs.

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I misunderstood the guidance - I suspect it's missing a resolution besides naming the problem. I suspect you were also trying to run make docs-api-local

@Nr18 Nr18 requested a review from heitorlessa September 1, 2020 11:00
@heitorlessa
Copy link
Contributor

heitorlessa commented Sep 1, 2020 via email

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding the troubleshooting section - It'll help us provide more prescriptive guidance when hitting these pesky issues ;)

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Sep 1, 2020
@heitorlessa heitorlessa merged commit c5e7085 into aws-powertools:develop Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants