-
Notifications
You must be signed in to change notification settings - Fork 421
docs: add troubleshooting section #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #151 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 705 705
Branches 68 68
=========================================
Hits 705 705 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I misunderstood the guidance - I suspect it's missing a resolution besides naming the problem. I suspect you were also trying to run make docs-api-local
Yes, unless you somehow (on purpose, pure evil) change directory and then
use poetry shell to run pdoc3 haha
…On Tue, 1 Sep 2020 at 13:02, Joris Conijn ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CONTRIBUTING.md
<#151 (comment)>
:
> @@ -69,6 +69,9 @@ ***@***.*** with any additional questions or comments.
## Security issue notifications
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue.
+## Troubleshooting
+
+* The local **API reference** throws a `Module aws_lambda_powertools not found` error when an exception is raised in the code-base, when you run `poetry run pdoc --pdf aws_lambda_powertools` the exception is shown.
Ah nice I added the make dev as a solution as well, the pdoc3 path can't
be wrong anymore since we run everything in a poetry shell right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#151 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBGXCBGUJQ4R433OH5LSDTIEFANCNFSM4QPX34CQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding the troubleshooting section - It'll help us provide more prescriptive guidance when hitting these pesky issues ;)
Issue #, if available:
Description of changes:
Add a troubleshooting section in the CONTRIBUTING.md
Checklist
Update testsBreaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.