feat(event_handler): add cookies as 1st class citizen in v2 #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
rubenfonseca
force-pushed
the
feat/cookies-v2
branch
2 times, most recently
from
97bd70f to
e93ae12
Compare
rubenfonseca
force-pushed
the
feat/cookies-v2
branch
from
e93ae12 to
a551fd5
Compare
|
@heitorlessa @leandrodamascena would appreciate early feedback on this one before I continue to apply changes |
rubenfonseca
commented
Aug 31, 2022
heitorlessa
suggested changes
Sep 1, 2022
boring-cyborg
bot
added
the
documentation
…ws-powertools#1455) Co-authored-by: Heitor Lessa <[email protected]>
rubenfonseca
force-pushed
the
feat/cookies-v2
branch
from
ff96266 to
fe4ea7d
Compare
heitorlessa
reviewed
Sep 2, 2022
heitorlessa
reviewed
Sep 2, 2022
heitorlessa
reviewed
Sep 2, 2022
| assert "MonsterCookie" in response.cookies.keys() | ||
| assert "CookieMonster" in response.cookies.keys() | ||
| # ALB sorts the header values randomly, so we have to re-order them for comparison here | ||
| returned_value = ", ".join(sorted(response.headers[key].split(", "))) |
There was a problem hiding this comment.
Note for us: maybe we should have an utility function for this as we'll forget at some point (syntax et al)
heitorlessa
approved these changes
Sep 2, 2022
rubenfonseca
changed the title
rubenfonseca
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Sep 2, 2022
Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Heitor Lessa <[email protected]>
heitorlessa
added a commit
that referenced
this pull request
Sep 9, 2022
* develop: chore(deps-dev): bump aws-cdk-lib from 2.40.0 to 2.41.0 (#1507) update changelog with latest changes feat(tracer): support methods with the same name (ABCs) by including fully qualified name in v2 (#1486) chore(deps-dev): bump aws-cdk-aws-apigatewayv2-integrations-alpha from 2.39.1a0 to 2.40.0a0 (#1496) chore(deps-dev): bump mkdocs-material from 8.4.2 to 8.4.3 (#1504) chore(deps): bump pydantic from 1.10.1 to 1.10.2 (#1502) update changelog with latest changes feat(data-classes): add KafkaEvent and KafkaEventRecord (#1485) chore(deps-dev): bump pytest from 7.1.2 to 7.1.3 (#1497) update changelog with latest changes feat(event_handler): add cookies as 1st class citizen in v2 (#1487) chore(deps-dev): bump black from 22.6.0 to 22.8.0 (#1494) chore(deps-dev): bump aws-cdk-lib from 2.39.1 to 2.40.0 (#1495) chore(maintenance): add discord link to first PR and first issue (#1493) update changelog with latest changes refactor(batch): remove legacy sqs_batch_processor (#1492) chore(deps): bump pydantic from 1.10.0 to 1.10.1 (#1491) chore(deps-dev): bump flake8-variables-names from 0.0.4 to 0.0.5 (#1490)
Tankanow
pushed a commit
to Tankanow/aws-lambda-powertools-python
that referenced
this pull request
Sep 13, 2022
…rtools#1487) Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Heitor Lessa <[email protected]>
Tankanow
pushed a commit
to Tankanow/aws-lambda-powertools-python
that referenced
this pull request
Sep 13, 2022
…rtools#1487) Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Heitor Lessa <[email protected]>
rubenfonseca
added a commit
that referenced
this pull request
Sep 14, 2022
Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Heitor Lessa <[email protected]>
rubenfonseca
added a commit
that referenced
this pull request
Oct 14, 2022
Co-authored-by: Heitor Lessa <[email protected]> Co-authored-by: Heitor Lessa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1192
Summary
This PR adds first class support for Cookies. After the last PR where we added multiple header values and cookies, we noticed we could improve the experience of Cookies by having a strongly typed class based approach.
Changes
I've added a class for
Cookiemodeling the most common options that are used today according to the RFC.It also updated and extends the E2E tests to be more comprehensive and generic.
User experience
Before, the user would have to encode the cookie himself, producing a string with the desired output:
This would be error prone, as getting the string right can be the source of bugs.
With the new class based Cookie, this becomes simpler:
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.