Skip to content

feat(ci): create reusable changelog generation #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Aug 5, 2022

Issue number: #1398

Summary

Changes

Please provide a summary of what's being changed

This PR introduces a reusable workflow to update changelog, and correct permissions that made release failed last time - both related to the introduction of changelog generation.

Tasks

  • include changelog generation on docs build
  • update release automated activities docs
  • add additional release input to accurately describe intent on skip
  • job permissions
  • read changelog step on release
  • create reusable changelog workflow
  • update rebuild latest doc workflow to use new changelog worklfow
  • correct race condition when files are changed halfway through changelogs are pushed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner August 5, 2022 07:44
@heitorlessa heitorlessa requested review from mploski and removed request for a team August 5, 2022 07:44
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Aug 5, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2022
@github-actions github-actions bot added the feature New feature or functionality label Aug 5, 2022
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for mploski August 5, 2022 07:46
@heitorlessa
Copy link
Contributor Author

thank you @rubenfonseca. Merging

@heitorlessa heitorlessa merged commit 2f628ad into aws-powertools:develop Aug 5, 2022
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality github-actions Pull requests that update Github_actions code size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants