Skip to content

chore(metrics): revert dimensions test and split #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jun 8, 2022

Resolves #1239

Summary

Changes

In #1240, I repurposed the original test test_exceed_number_of_dimensions to account for service dimension, since the outcome would be the same (SchemaValidationError).

This PR reverts that test change, fix an old typo (we we), and adds a specific test test_exceed_number_of_dimensions_with_service.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the tests label Jun 8, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 8, 2022
@heitorlessa heitorlessa added the internal Maintenance changes label Jun 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #1243 (1afa990) into develop (9d8dd1b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1243   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files          119      119           
  Lines         5423     5423           
  Branches       618      618           
========================================
  Hits          5417     5417           
  Misses           2        2           
  Partials         4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8dd1b...1afa990. Read the comment docs.

@heitorlessa heitorlessa merged commit 5d5e7b8 into aws-powertools:develop Jun 8, 2022
@heitorlessa heitorlessa changed the title chore(metrics): revert dimensions test before splitting chore(metrics): revert dimensions test and split Jun 8, 2022
@heitorlessa heitorlessa deleted the chore/split-metrics-dimension-test branch June 8, 2022 05:56
@heitorlessa heitorlessa linked an issue Jun 10, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: publishing a metric with 9 dimensions doesn't work
2 participants