fix(deps-dev): remove jmespath due to dev deps conflict #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
boring-cyborg
bot
added
the
dependencies
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
heitorlessa
suggested changes
Apr 21, 2022
| @@ -24,10 +24,6 @@ python = "^3.6.2" | |||
| aws-xray-sdk = "^2.8.0" | |||
| fastjsonschema = "^2.14.5" | |||
| boto3 = "^1.18" | |||
There was a problem hiding this comment.
Could you add a comment here so we review jmespath state after 3.6 Lambda deprecation?
I think we can trust boto to not drop jmespath given how crucial it is for them, but I wanna be conservative as (1) it doesn't add any extra bytes at runtime, and (2) jmespath hasn't been updated in years
There was a problem hiding this comment.
After this we can merge it!
heitorlessa
approved these changes
Apr 21, 2022
heitorlessa
changed the title
heitorlessa
changed the title
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1147
Summary
Removes JMESPath to allow downstream deps to solve this.
Changes
Removes JMESPath dependency from
pyproject.tomlUser experience
See issue (#1147)
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.