fix: browser-encrypt can encrypt 0 bytes #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browser encryption now correctly encrypts 0 byte messages. Added structural tests for both Node.js and browser `encrypt`.
alex-chew
previously approved these changes
Mar 10, 2022
| @@ -370,6 +370,34 @@ describe('encrypt structural testing', () => { | |||
| // This will throw if it does not deserialize correctly | |||
| deserializeSignature(footerSection) | |||
| }) | |||
|
|
|||
| it('can encrypt empty message', async () => { | |||
There was a problem hiding this comment.
nit: any reason to check the encryption context and EDKs in the browser version of this test but not the Node version?
There was a problem hiding this comment.
to elaborate more, when encrypting 0 bytes, the only part of the message that is relevant is the encryption context :)
Co-authored-by: Alex Chew <[email protected]>
alex-chew
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser encryption now correctly encrypts 0 byte messages.
Added structural tests for both Node.js and browser
encrypt.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: