feat(node): support node v16 #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

texastony merged 43 commits into aws:master from texastony:chore_update_deps

Nov 5, 2021

Contributor

texastony commented Sep 16, 2021 •

edited

Loading

Issue #, if available: #740, #739, #738, #737, #731, #716, #714, #710, #642

Description of changes: Update dependencies.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

texastony added 2 commits

September 16, 2021 17:08


          chore(dependencies): update dependencies to latest as of 2021/09/16

e944f5c


          chore(dependencies): address breaking changes from typescript upgrade

b74abd7

texastony commented

View reviewed changes

modules/integration-node/src/decrypt_materials_manager_node.ts Show resolved Hide resolved

texastony commented

View reviewed changes

modules/kms-keyring/src/kms_keyring.ts Outdated Show resolved Hide resolved

texastony commented

View reviewed changes

modules/raw-rsa-keyring-browser/src/raw_rsa_keyring_web_crypto.ts Outdated Show resolved Hide resolved

texastony commented

View reviewed changes

package.json Outdated Show resolved Hide resolved

texastony commented

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

texastony commented

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved


          style(integration-browser): correct for prettier

d39663c

seebees reviewed

View reviewed changes

modules/decrypt-node/src/verify_stream.ts Outdated Show resolved Hide resolved

seebees reviewed

View reviewed changes

modules/integration-node/src/cli.ts Outdated Show resolved Hide resolved

seebees reviewed

View reviewed changes

modules/integration-vectors/src/index.ts Outdated Show resolved Hide resolved

texastony added 4 commits

September 17, 2021 18:03


          fix(kms-keyring): introduce ErrorPlus to handle catch unknown

bbbbd74


          fix(kms-keyring): apply ErrorPlus to mrk_keyrings

cb1de57


          refactor(integration-node): await command from yargs addresses TS2339

db02665


          style(raw-rsa-keyring-browser): specifiy return of exported function …

b7fbd96

…getImportOptions

texastony requested a review from seebees

September 18, 2021 14:25

seebees reviewed

View reviewed changes

modules/integration-browser/src/integration.encrypt.test.ts Outdated Show resolved Hide resolved

seebees reviewed

View reviewed changes

modules/integration-browser/src/testDecryptFixture.ts Outdated Show resolved Hide resolved

seebees reviewed

View reviewed changes

modules/material-management/src/types.ts Outdated Show resolved Hide resolved

seebees reviewed

View reviewed changes

modules/raw-rsa-keyring-browser/src/raw_rsa_keyring_web_crypto.ts Outdated Show resolved Hide resolved

texastony added 2 commits

September 20, 2021 13:45


          fix(package-lock): package-lock was generated w/ npm6, needed 7

f637165


          docs(raw-rsa-keyring-browser): document TS2769 override issue

4f9ddd8

texastony commented

View reviewed changes

modules/example-browser/package.json Show resolved Hide resolved

texastony added 4 commits

October 27, 2021 18:33


          refactor(material-management-node): encapsulate crypto's sign(er) and…

72fdfe8

… verify


          chore(merge): pull v3.0.3 onto chore_update_deps

584839b


          refactor(material-management-node): encapsulate crypto's sign(er) & v…

9b4e48d

…erify


          docs(material-management-node): add liscense to types

df3ced3

texastony changed the title ~~chore(dependencies): update dependencies to latest as of 2021/09/16~~ feat(node): support node v16

Contributor Author

texastony commented Oct 28, 2021

To verify that this works with node v14, I ran the following:

npm run clean; rm -rf node_modules; 
nvm use 14;
npm ci; npm test;

I verified that this worked with node v16 by generating the package-lock.json with node v16.

texastony added 10 commits

October 29, 2021 17:12


          ci(node16): manually install node16 and test

0aeb35f


          ci(node16): manually install node16 and test

84a7a7d


          ci(node16): manually install node16 and test

7652a2d


          ci(node16): manually install node16 and test

b1d5237


          ci(node16): manually install node16 and test

d992fa9


          ci(node16): manually install node16 and test

8285b86


          ci(node16): run integration test vectors

18bd0a8


          ci(node16): run integration test vectors

9753db5


          ci(node16): run integration test vectors

d55d85e


          ci(node14): temporarily remove node14 vectors

d3d857e

We have exceeded our build batch limit.
This is a temporary work-around.
Will revert this commit before merge.

texastony marked this pull request as draft

October 30, 2021 13:05


          revert: "ci(node14): temporarily remove node14 vectors"

61668bb

Refs: d3d857e

texastony marked this pull request as ready for review

November 1, 2021 15:06

Contributor Author

texastony commented Nov 1, 2021

This build will fail because the build limit has not been increased yet.

texastony added 3 commits

November 1, 2021 16:19


          ci: force new ci run

00c9036


          ci: force new ci run

4f1c85d


          ci(buildspec): use aws/codebuild/standard:5.0

20bb6e8

seebees requested changes

View reviewed changes

codebuild/nodejs16.yml Outdated Show resolved Hide resolved

codebuild/test_vectors/nodejs16.yml Outdated Show resolved Hide resolved

modules/material-management/src/needs.ts Outdated Show resolved Hide resolved

modules/raw-rsa-keyring-browser/src/raw_rsa_keyring_web_crypto.ts Outdated Show resolved Hide resolved


          fix: importKey overload issue

525ba2e

TS is not able to select the proper overload.
Giving it some help resolve the issue.

texastony commented

View reviewed changes

Contributor Author

texastony left a comment

Awesome. I spent hours trying different things, glad it was figured out!

texastony commented

View reviewed changes

modules/raw-rsa-keyring-node/src/oaep_hash_supported.ts Show resolved Hide resolved


          ci(CodeBuild): use n

f37df2f

seebees previously approved these changes

View reviewed changes

Contributor

seebees left a comment

LGTM


          refactor(material-management): move NotSupported to error.ts

8c447e7

texastony dismissed seebees’s stale review via

8c447e7

November 5, 2021 16:28

seebees previously approved these changes

View reviewed changes

Contributor

seebees left a comment

Good :)


          style(material-management): prettier

d0cb60f

texastony dismissed seebees’s stale review via

d0cb60f

November 5, 2021 16:59

seebees approved these changes

View reviewed changes

texastony merged commit 66e63b5 into aws:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet