Skip to content

fix: Update @types/node to 16.7.9 #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

cernytomas
Copy link
Contributor

Issue #722

Description of changes:

Updated @types/node to 16.7.8
Renamed Signer to Sign

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@cernytomas cernytomas changed the title Update @types/node to 16.7.8 fix: Update @types/node to 16.7.8 Aug 31, 2021
@cernytomas cernytomas force-pushed the update-types-node-version branch from 37cf31f to f585021 Compare August 31, 2021 08:09
@cernytomas cernytomas force-pushed the update-types-node-version branch from f585021 to 7747725 Compare August 31, 2021 20:03
@cernytomas cernytomas changed the title fix: Update @types/node to 16.7.8 fix: Update @types/node to 16.7.9 Aug 31, 2021
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋!

Thank you for contributing to the AWS Encryption SDK JavaScript.
Your changes have been approved!

@josecorella josecorella merged commit 7ba9425 into aws:master Sep 7, 2021
@corrjo
Copy link

corrjo commented Sep 20, 2021

After this update I'm getting

node_modules/@aws-crypto/material-management-node/build/main/src/material_helpers.d.ts:3:10 - error TS2724: '"crypto"' has no exported member named 'Sign'. Did you mean 'sign'?

3 import { Sign, Verify, createCipheriv, createDecipheriv } from 'crypto';
           ~~~~

  node_modules/@types/node/crypto.d.ts:1159:14
    1159     function sign(
                      ~~~~
    'sign' is declared here.

@corrjo
Copy link

corrjo commented Sep 20, 2021

I see, @types/node 14 vs 16 issue.

I know node 16 is becoming lts in a few weeks, but pushing out a breaking change while the active LTS is 14, and then releasing it as a patch kind of sucks.

@texastony
Copy link
Contributor

Howdy @corrjo,

Thank you for bringing this to our attention.
We will issue a rollback.

Our goal is to ensure that our dependencies
are not public in ways that break our customer's code.

Much Obliged,
AWS Crypto Tools

texastony added a commit to texastony/aws-encryption-sdk-javascript that referenced this pull request Sep 21, 2021
@tomasstrejcek
Copy link

what a pain :) maybe you could have directly release new minor version supporting new version because both of those are breaking changes, which have no place in a crucial modules like these? :(

@cernytomas
Copy link
Contributor Author

Hi @texastony,
node v16 is LTS now, so it's time to revert your revert :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants