-
Notifications
You must be signed in to change notification settings - Fork 63
fix: Update @types/node to 16.7.9 #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
37cf31f
to
f585021
Compare
f585021
to
7747725
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello 👋!
Thank you for contributing to the AWS Encryption SDK JavaScript.
Your changes have been approved!
After this update I'm getting
|
I see, @types/node 14 vs 16 issue. I know node 16 is becoming lts in a few weeks, but pushing out a breaking change while the active LTS is 14, and then releasing it as a patch kind of sucks. |
Howdy @corrjo, Thank you for bringing this to our attention. Our goal is to ensure that our dependencies Much Obliged, |
This reverts commit 7ba9425.
what a pain :) maybe you could have directly release new minor version supporting new version because both of those are breaking changes, which have no place in a crucial modules like these? :( |
Hi @texastony, |
Issue #722
Description of changes:
Updated @types/node to 16.7.8
Renamed
Signer
toSign
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: