fix: der2raw sLength is s byte length #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raw signature (also see ISO/IEC 7816-8 / IEEE P1363) are the static size concatenation of the r and s value. These values MUST be 0 padded to the correct length. This fixes the occasional `Invalid Signature` in browsers. This impacts ~1% of messages. These messages are valid and can now be decrypted.
texastony
requested changes
Jun 29, 2021
|
|
||
| // Suite AlgorithmSuiteIdentifier.ALG_AES256_GCM_IV12_TAG16_HKDF_SHA512_COMMIT_KEY_ECDSA_P384 | ||
| // prettier-ignore | ||
| const derSigOnlySPadded = new Uint8Array([ |
There was a problem hiding this comment.
Only concerns me, as it raises confusion. Given all I know, I assume that derSigOnlySPadded is different from derSigSPadded, and the difference is that r = 0, is that right? If not, what is the difference?
There was a problem hiding this comment.
I don't like to delete vectors. How about numbers? derSigSPadded derSigSPadded1 derSigSPadded2`?
| ) | ||
| }) | ||
|
|
||
| it('New vector S only padded', () => { |
There was a problem hiding this comment.
Very minor: I hate/despise New in a repo. It is New today, it is old tomorrow. Is there some other adjective we can use that possible addresses the Only comment above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raw signature (also see ISO/IEC 7816-8 / IEEE P1363)
are the static size concatenation of the r and s value.
These values MUST be 0 padded to the correct length.
This fixes the occasional
Invalid Signaturein browsers.This impacts ~1% of messages.
These messages are valid and can now be decrypted.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: