Skip to content

fix: add serializationOptions flag for AAD UTF8 sorting #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 9, 2025

Conversation

josecorella
Copy link
Contributor

@josecorella josecorella commented Apr 8, 2025

Issue #, if available:
addresses #428

Description of changes:
see https://github.com/aws/private-aws-encryption-sdk-javascript-staging/pull/769

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@josecorella josecorella requested a review from a team as a code owner April 8, 2025 18:35
@josecorella josecorella force-pushed the jocorell/fix-aad-serialization-sorting branch from a83a36f to a7f2793 Compare April 8, 2025 18:37
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josecorella josecorella merged commit b80cad1 into master Apr 9, 2025
9 checks passed
@josecorella josecorella deleted the jocorell/fix-aad-serialization-sorting branch April 9, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants