Skip to content

Context copying is disabling default dimensions #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markkuhn opened this issue Oct 12, 2022 · 0 comments · Fixed by #128
Closed

Context copying is disabling default dimensions #127

markkuhn opened this issue Oct 12, 2022 · 0 comments · Fixed by #128
Assignees
Labels
bug Something isn't working

Comments

@markkuhn
Copy link
Contributor

Issue

When flushPreserveDimensions is true, the context will disable default dimensions after the first flush.

Reproduction

MetricsLogger logger = new MetricsLogger(environment);
logger.putMetric("Example", 100);
logger.flush();
logger.putMetric("Example", 200);
logger.flush(); // This logger will not contain any default dimensions

Cause

Context copy uses setDimensions() to copy custom dimensions which disables default dimensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants