Skip to content

Commit e2a28ae

Browse files
committed
updated Metric.getSimplifiedValues() to Metric.getFormattedValues()
1 parent 9fd3833 commit e2a28ae

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

src/main/java/software/amazon/cloudwatchlogs/emf/model/Metric.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616

1717
package software.amazon.cloudwatchlogs.emf.model;
1818

19-
import com.fasterxml.jackson.annotation.JsonIgnore;
2019
import com.fasterxml.jackson.annotation.JsonInclude;
2120
import com.fasterxml.jackson.annotation.JsonProperty;
2221
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
2322
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
23+
2424
import lombok.Getter;
2525
import software.amazon.cloudwatchlogs.emf.serializers.StorageResolutionFilter;
2626
import software.amazon.cloudwatchlogs.emf.serializers.StorageResolutionSerializer;
@@ -48,7 +48,13 @@ public abstract class Metric {
4848
@JsonSerialize(using = StorageResolutionSerializer.class)
4949
protected StorageResolution storageResolution;
5050

51-
@JsonIgnore @Getter protected Object values;
51+
/** @return the values stored by this metric. */
52+
abstract Object getValues();
53+
54+
/** @return a simplified representation of the values of this metric. */
55+
protected Object getFormattedValues() {
56+
return this.getValues();
57+
}
5258

5359
/**
5460
* Change the name of this metric. Should only be used within this package in MetricContext when
@@ -80,7 +86,4 @@ protected void setName(String name) {
8086
* metric. If there are less than {@code size} values, null is returned.
8187
*/
8288
protected abstract Metric getMetricValuesOverSize(int size);
83-
84-
/** @return a simplified representation of the values of this metric. */
85-
protected abstract Object getSimplifiedValues();
8689
}

src/main/java/software/amazon/cloudwatchlogs/emf/model/MetricDefinitionBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ protected Metric getMetricValuesOverSize(int size) {
6868
* one value
6969
*/
7070
@Override
71-
protected Object getSimplifiedValues() {
71+
protected Object getFormattedValues() {
7272
return values.size() == 1 ? values.get(0) : values;
7373
}
7474
}

src/main/java/software/amazon/cloudwatchlogs/emf/model/RootNode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ Map<String, Object> getTargetMembers() throws DimensionSetExceededException {
6666
targetMembers.putAll(getDimensions());
6767
for (MetricDirective metricDirective : aws.getCloudWatchMetrics()) {
6868
for (Metric metric : metricDirective.getMetrics().values()) {
69-
targetMembers.put(metric.getName(), metric.getSimplifiedValues());
69+
targetMembers.put(metric.getName(), metric.getFormattedValues());
7070
}
7171
}
7272
return targetMembers;

0 commit comments

Comments
 (0)