Skip to content

Commit 58fed25

Browse files
authored
Add test coverage for pull request #69 (#70)
1 parent fb4305c commit 58fed25

File tree

3 files changed

+31
-2
lines changed

3 files changed

+31
-2
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ For more information on using the amazon-sqs-java-extended-client-lib, see our g
2525
<dependency>
2626
<groupId>com.amazonaws</groupId>
2727
<artifactId>amazon-sqs-java-extended-client-lib</artifactId>
28-
<version>2.0.1</version>
28+
<version>2.0.2</version>
2929
<type>jar</type>
3030
</dependency>
3131
```

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>com.amazonaws</groupId>
88
<artifactId>amazon-sqs-java-extended-client-lib</artifactId>
9-
<version>2.0.1</version>
9+
<version>2.0.2</version>
1010
<packaging>jar</packaging>
1111
<name>Amazon SQS Extended Client Library for Java</name>
1212
<description>An extension to the Amazon SQS client that enables sending and receiving messages up to 2GB via Amazon S3.

src/test/java/com/amazon/sqs/javamessaging/AmazonSQSExtendedClientTest.java

+29
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
import static com.amazon.sqs.javamessaging.AmazonSQSExtendedClient.USER_AGENT_NAME;
6060
import static com.amazon.sqs.javamessaging.AmazonSQSExtendedClient.USER_AGENT_VERSION;
6161
import static org.junit.Assert.assertEquals;
62+
import static org.junit.Assert.assertNotEquals;
6263
import static org.mockito.Matchers.any;
6364
import static org.mockito.Matchers.eq;
6465
import static org.mockito.Mockito.doThrow;
@@ -429,6 +430,34 @@ public void testWhenMessageBatchIsSentThenOnlyMessagesLargerThanThresholdAreStor
429430
verify(mockS3, times(8)).putObject(isA(PutObjectRequest.class), isA(RequestBody.class));
430431
}
431432

433+
@Test
434+
public void testWhenMessageBatchIsLargeS3PointerIsCorrectlySentToSQSAndNotOriginalMessage() {
435+
String messageBody = generateStringWithLength(LESS_THAN_SQS_SIZE_LIMIT);
436+
ExtendedClientConfiguration extendedClientConfiguration = new ExtendedClientConfiguration()
437+
.withPayloadSupportEnabled(mockS3, S3_BUCKET_NAME).withAlwaysThroughS3(true);
438+
439+
SqsClient sqsExtended = spy(new AmazonSQSExtendedClient(mockSqsBackend, extendedClientConfiguration));
440+
441+
List<SendMessageBatchRequestEntry> batchEntries = new ArrayList<SendMessageBatchRequestEntry>();
442+
for (int i = 0; i < 10; i++) {
443+
SendMessageBatchRequestEntry entry = SendMessageBatchRequestEntry.builder()
444+
.id("entry_" + i)
445+
.messageBody(messageBody)
446+
.build();
447+
batchEntries.add(entry);
448+
}
449+
SendMessageBatchRequest batchRequest = SendMessageBatchRequest.builder().queueUrl(SQS_QUEUE_URL).entries(batchEntries).build();
450+
451+
sqsExtended.sendMessageBatch(batchRequest);
452+
453+
ArgumentCaptor<SendMessageBatchRequest> sendMessageRequestCaptor = ArgumentCaptor.forClass(SendMessageBatchRequest.class);
454+
verify(mockSqsBackend).sendMessageBatch(sendMessageRequestCaptor.capture());
455+
456+
for (SendMessageBatchRequestEntry entry : sendMessageRequestCaptor.getValue().entries()) {
457+
assertNotEquals(messageBody, entry.messageBody());
458+
}
459+
}
460+
432461
@Test
433462
public void testWhenSmallMessageIsSentThenNoAttributeIsAdded() {
434463
String messageBody = generateStringWithLength(LESS_THAN_SQS_SIZE_LIMIT);

0 commit comments

Comments
 (0)