From a2e5890f7a95d46ab11ce3b63337957f914f3044 Mon Sep 17 00:00:00 2001 From: Lauren Yu <6631887+laurenyu@users.noreply.github.com> Date: Tue, 22 Oct 2019 13:38:55 -0700 Subject: [PATCH 1/2] fix: update documentation link in warning message --- src/sagemaker_tensorflow_container/training.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/sagemaker_tensorflow_container/training.py b/src/sagemaker_tensorflow_container/training.py index 31614896..5b176a28 100644 --- a/src/sagemaker_tensorflow_container/training.py +++ b/src/sagemaker_tensorflow_container/training.py @@ -169,7 +169,7 @@ def _log_model_missing_warning(model_dir): pb_file_exists = True path, direct_parent_dir = os.path.split(dirpath) if not str.isdigit(direct_parent_dir): - logger.warn('Your model will NOT be servable with SageMaker TensorFlow Serving containers.' + logger.warn('Your model will NOT be servable with SageMaker TensorFlow Serving containers. ' 'The SavedModel bundle is under directory \"{}\", not a numeric name.' .format(direct_parent_dir)) @@ -177,10 +177,10 @@ def _log_model_missing_warning(model_dir): logger.warn('No model artifact is saved under path {}.' ' Your training job will not save any model files to S3.\n' 'For details of how to construct your training script see:\n' - 'https://github.com/aws/sagemaker-python-sdk/tree/master/src/sagemaker/tensorflow#adapting-your-local-tensorflow-script' # noqa + 'https://sagemaker.readthedocs.io/en/stable/using_tf.html#adapting-your-local-tensorflow-script' .format(model_dir)) elif not pb_file_exists: - logger.warn('Your model will NOT be servable with SageMaker TensorFlow Serving container.' + logger.warn('Your model will NOT be servable with SageMaker TensorFlow Serving container. ' 'The model artifact was not saved in the TensorFlow SavedModel directory structure:\n' 'https://www.tensorflow.org/guide/saved_model#structure_of_a_savedmodel_directory') From cbc92a3510affb1df70b80d4875abbcca2b51ddd Mon Sep 17 00:00:00 2001 From: Lauren Yu <6631887+laurenyu@users.noreply.github.com> Date: Wed, 23 Oct 2019 11:52:39 -0700 Subject: [PATCH 2/2] fix unit tests --- test/unit/test_training.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/unit/test_training.py b/test/unit/test_training.py index db7d941b..f49d34ed 100644 --- a/test/unit/test_training.py +++ b/test/unit/test_training.py @@ -209,14 +209,14 @@ def test_log_model_missing_warning_no_model(logger): logger.warn.assert_called_with('No model artifact is saved under path {}.' ' Your training job will not save any model files to S3.\n' 'For details of how to construct your training script see:\n' - 'https://github.com/aws/sagemaker-python-sdk/tree/master/src/sagemaker/tensorflow#adapting-your-local-tensorflow-script' # noqa + 'https://sagemaker.readthedocs.io/en/stable/using_tf.html#adapting-your-local-tensorflow-script' # noqa .format(path)) @patch('sagemaker_tensorflow_container.training.logger') def test_log_model_missing_warning_wrong_format(logger): training._log_model_missing_warning(os.path.join(RESOURCE_PATH, 'test_dir_wrong_model')) - logger.warn.assert_called_with('Your model will NOT be servable with SageMaker TensorFlow Serving container.' + logger.warn.assert_called_with('Your model will NOT be servable with SageMaker TensorFlow Serving container. ' 'The model artifact was not saved in the TensorFlow ' 'SavedModel directory structure:\n' 'https://www.tensorflow.org/guide/saved_model#structure_of_a_savedmodel_directory') @@ -225,7 +225,7 @@ def test_log_model_missing_warning_wrong_format(logger): @patch('sagemaker_tensorflow_container.training.logger') def test_log_model_missing_warning_wrong_parent_dir(logger): training._log_model_missing_warning(os.path.join(RESOURCE_PATH, 'test_dir_wrong_parent_dir')) - logger.warn.assert_called_with('Your model will NOT be servable with SageMaker TensorFlow Serving containers.' + logger.warn.assert_called_with('Your model will NOT be servable with SageMaker TensorFlow Serving containers. ' 'The SavedModel bundle is under directory \"{}\", not a numeric name.' .format('not-digit'))