Skip to content

Commit 747c819

Browse files
authored
Merge pull request #144 from aws/arm-buildspec
ARM Build Spec Fix
2 parents 8600e2a + 3184a9a commit 747c819

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

ci/buildspec_arm.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,11 @@ phases:
3030
- pip install wheel setuptools
3131
- python setup.py bdist_wheel
3232
- docker build -t preprod-sklearn:$FRAMEWORK_VERSION-cpu-py3-arm64 -f docker/$FRAMEWORK_VERSION/final/Dockerfile_arm.cpu .
33-
- echo Running tox...
33+
- echo Running tests...
3434
- printf "FROM preprod-sklearn:$FRAMEWORK_VERSION-cpu-py3-arm64\nADD . /app\nWORKDIR /app\nRUN python3 -m pip install .[test]" > Dockerfile_arm.test
3535
- docker build -t test-sklearn -f Dockerfile_arm.test .
36-
- docker run --rm -t test-sklearn sh -c 'tox -e ALL'
36+
- docker run --rm -t test-sklearn sh -c 'pytest --cov=sagemaker_sklearn_container --cov-fail-under=60 test/unit'
37+
- docker run --rm -t test-sklearn sh -c 'flake8 setup.py src test'
3738
- echo Running container tests...
3839
- pytest test/integration --docker-base-name preprod-sklearn --tag $FRAMEWORK_VERSION-cpu-py3-arm64 --py-version 3 --framework-version $FRAMEWORK_VERSION
3940
- docker tag preprod-sklearn:$FRAMEWORK_VERSION-cpu-py3-arm64 515193369038.dkr.ecr.us-west-2.amazonaws.com/sagemaker-scikit-learn:$FRAMEWORK_VERSION-cpu-py3-arm64

docker/1.0-1/base/Dockerfile_arm.cpu

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ARG MINICONDA_VERSION=4.9.2 # Upgraded version
77
ARG CONDA_PY_VERSION=38
88
ARG CONDA_PKG_VERSION=4.10.1
99
ARG PYTHON_VERSION=3.8.13
10-
ARG PYARROW_VERSION=1.0
10+
ARG PYARROW_VERSION=1.0.0
1111
ARG MLIO_VERSION=arch-agnostic
1212

1313
# Install python and other scikit-learn runtime dependencies

docker/1.0-1/final/Dockerfile_arm.cpu

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM sklearn-base:1.0-1-arm-cpu-py3
1+
FROM sklearn-base:1.0-1-cpu-py3-arm64
22
ENV SAGEMAKER_SKLEARN_VERSION 1.0-1
33

44
LABEL com.amazonaws.sagemaker.capabilities.accept-bind-to-port=true
@@ -49,7 +49,7 @@ ENV SM_CHECKPOINT_CONFIG_FILE $SM_INPUT/config/checkpointconfig.json
4949
# Set SageMaker serving environment variables
5050
ENV SM_MODEL_DIR /opt/ml/model
5151

52-
#EXPOSE 8080
52+
EXPOSE 8080
5353
ENV TEMP=/home/model-server/tmp
5454

5555
# Required label for multi-model loading

0 commit comments

Comments
 (0)