Skip to content

Commit 342c105

Browse files
author
Nikhil Raverkar
committed
reverting numpy to 1.19.2 to solve pyarrow integration issue, changes to resolve numpy related build issues and adding regression test
1 parent f8015ce commit 342c105

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

docker/0.23-1/final/Dockerfile.cpu

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ RUN python -m pip install -r /requirements.txt && \
99

1010
COPY dist/sagemaker_sklearn_container-2.0-py3-none-any.whl /sagemaker_sklearn_container-2.0-py3-none-any.whl
1111
# https://github.com/googleapis/google-cloud-python/issues/6647
12-
RUN rm -rf /miniconda3/lib/python3.7/site-packages/numpy-1.19.4.dist-info && \
12+
RUN conda install numpy --force-reinstall
13+
rm -rf /miniconda3/lib/python3.7/site-packages/numpy-1.19.4.dist-info && \
1314
pip install --no-cache /sagemaker_sklearn_container-2.0-py3-none-any.whl && \
14-
rm /sagemaker_sklearn_container-2.0-py3-none-any.whl
15+
rm /sagemaker_sklearn_container-2.0-py3-none-any.whl && \
16+
rm /miniconda3/lib/python3.8/site-packages/numpy-1.21.2.dist-info
1517

1618
ENV SAGEMAKER_TRAINING_MODULE sagemaker_sklearn_container.training:main
1719
ENV SAGEMAKER_SERVING_MODULE sagemaker_sklearn_container.serving:main

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ itsdangerous==2.0.1
66
gunicorn==20.0.4
77
model-archiver==1.0.3
88
multi-model-server==1.1.1
9-
numpy==1.21.0
9+
numpy==1.19.2
1010
pandas==1.1.3
1111
psutil==5.7.2
1212
python-dateutil==2.8.1

test/unit/test_modules.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
1+
import pandas as pd
2+
3+
14
def test_pandas_version():
25
import pandas as pd
36
major, minor, patch = pd.__version__.split('.')
47
assert major == '1'
8+
9+
10+
def test_pyarrow_to_parquet_conversion_regression_issue_106():
11+
df = pd.DataFrame({'x': [1, 2]})
12+
df.to_parquet('test.parquet', engine='pyarrow')
13+

0 commit comments

Comments
 (0)