Skip to content

feature: Add Neo image uri config for Pytorch 1.12 #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2022
Merged

feature: Add Neo image uri config for Pytorch 1.12 #3507

merged 2 commits into from
Dec 7, 2022

Conversation

HappyAmazonian
Copy link
Contributor

Issue #, if available:

Description of changes:
Neo supports compilation for pytorch 1.12. Add related config for image_uri.

Testing done:

unit tests passed

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HappyAmazonian HappyAmazonian requested a review from a team as a code owner December 5, 2022 23:14
@HappyAmazonian HappyAmazonian requested review from claytonparnell and removed request for a team December 5, 2022 23:14
@knikure knikure self-assigned this Dec 5, 2022
knikure
knikure reviewed Dec 5, 2022
View reviewed changes
Copy link
Contributor

@knikure knikure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 5d4c3e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 5d4c3e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 5d4c3e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 5d4c3e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 5d4c3e2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure
knikure reviewed Dec 6, 2022
View reviewed changes
Copy link
Contributor

@knikure knikure left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 5d4c3e2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022 •
edited
Loading

Codecov Report

Merging #3507 (9c5fb18) into master (32969da) will decrease coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3507      +/-   ##
==========================================
- Coverage   89.71%   88.89%   -0.82%     
==========================================
  Files         900      212     -688     
  Lines       82908    20493   -62415     
==========================================
- Hits        74377    18217   -56160     
+ Misses       8531     2276    -6255
Impacted Files Coverage Δ
...n3.9/site-packages/sagemaker/workflow/fail_step.py
...3.9/site-packages/sagemaker/jumpstart/accessors.py
.../python3.10/site-packages/sagemaker/local/image.py
...3.10/site-packages/sagemaker/workflow/functions.py
...site-packages/sagemaker/debugger/metrics_config.py
...3.8/site-packages/sagemaker/tensorflow/defaults.py
...ite-packages/sagemaker/jumpstart/notebook_utils.py
...ite-packages/sagemaker/jumpstart/notebook_utils.py
...emaker/async_inference/async_inference_response.py
...b/python3.10/site-packages/sagemaker/exceptions.py
... and 1102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9c5fb18
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9c5fb18
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9c5fb18
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9c5fb18
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9c5fb18
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure changed the title feature add Neo image uri config for Pytorch 1.12 feature: Add Neo image uri config for Pytorch 1.12 Dec 7, 2022
@knikure knikure merged commit d779d1b into aws:master Dec 7, 2022
mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022
@HappyAmazonian @mizanfiu
feature: Add Neo image uri config for Pytorch 1.12 (aws#3507)
a1c8166
mufaddal-rohawala pushed a commit to mufaddal-rohawala/sagemaker-python-sdk that referenced this pull request Dec 19, 2022
@HappyAmazonian @mufiAmazon
feature: Add Neo image uri config for Pytorch 1.12 (aws#3507)
9982f57
mufaddal-rohawala pushed a commit that referenced this pull request Dec 20, 2022
@HappyAmazonian @mufiAmazon
feature: Add Neo image uri config for Pytorch 1.12 (#3507)
225ccf7
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@HappyAmazonian @JoseJuan98
feature: Add Neo image uri config for Pytorch 1.12 (aws#3507)
00632da
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@HappyAmazonian @JoseJuan98
feature: Add Neo image uri config for Pytorch 1.12 (aws#3507)
7d5ab0a
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@HappyAmazonian @mufiAmazon
feature: Add Neo image uri config for Pytorch 1.12 (aws#3507)
e85737f
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@HappyAmazonian
feature: Add Neo image uri config for Pytorch 1.12 (aws#3507)
797c2fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huiqunli huiqunli huiqunli approved these changes

@knikure knikure knikure approved these changes

@claytonparnell claytonparnell Awaiting requested review from claytonparnell claytonparnell is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees

@knikure knikure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HappyAmazonian @sagemaker-bot @codecov-commenter @huiqunli @knikure