Skip to content

fix: jumpstart docs network isolation #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2022
Merged

fix: jumpstart docs network isolation #2989

merged 1 commit into from
Mar 16, 2022

Conversation

evakravi
Copy link
Member

@evakravi evakravi commented Mar 11, 2022 •
edited
Loading

Issue #, if available:

Description of changes:
Fix/jumpstart docs network isolation. JumpStart xgboost and sklearn models require network isolation to be turned on for inference. All other models can also work in network isolation mode. In order to ensure customers are able to launch all models, we'd like to have the official documentation use network isolation mode. This is a temporary solution while JumpStart team debugs the issue at the root cause.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022 •
edited
Loading

Codecov Report

Merging #2989 (6d368f0) into master (7e2c7ab) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
- Coverage   89.90%   89.83%   -0.08%     
==========================================
  Files        1028      196     -832     
  Lines       83848    16596   -67252     
==========================================
- Hits        75386    14909   -60477     
+ Misses       8462     1687    -6775
Impacted Files Coverage Δ
...hon3.8/site-packages/sagemaker/sparkml/__init__.py
....8/site-packages/sagemaker/feature_store/inputs.py
...ite-packages/sagemaker/async_inference/__init__.py
.../site-packages/sagemaker/workflow/_repack_model.py
...ython3.9/site-packages/sagemaker/spark/defaults.py
....7/site-packages/sagemaker/jumpstart/parameters.py
.../py37/lib/python3.7/site-packages/sagemaker/job.py
...ython3.8/site-packages/sagemaker/lineage/_utils.py
...agemaker/cli/compatibility/v2/modifiers/parsing.py
...on3.6/site-packages/sagemaker/amazon/record_pb2.py
... and 822 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2c7ab...6d368f0. Read the comment docs.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: c3fd22b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: c3fd22b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: c3fd22b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@evakravi evakravi requested review from JGuinegagne March 14, 2022 17:46
@ahsan-z-khan ahsan-z-khan changed the base branch from dev to master March 14, 2022 18:06
@ahsan-z-khan ahsan-z-khan changed the title Fix/jumpstart docs network isolation Fix: jumpstart docs network isolation Mar 14, 2022
ahsan-z-khan
ahsan-z-khan suggested changes Mar 14, 2022
View reviewed changes
Copy link
Member

@ahsan-z-khan ahsan-z-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase? Shows 16 commits which are not related

@evakravi evakravi force-pushed the fix/jumpstart-docs-network-isolation branch from c3fd22b to 6d368f0 Compare March 15, 2022 13:37
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6d368f0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6d368f0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6d368f0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala mufaddal-rohawala changed the title Fix: jumpstart docs network isolation fix: jumpstart docs network isolation Mar 16, 2022
@mufaddal-rohawala mufaddal-rohawala merged commit a065e8b into aws:master Mar 16, 2022
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022
@evakravi @jerrypeng7773
fix: jumpstart docs network isolation (aws#2989)
f6689a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsan-z-khan ahsan-z-khan ahsan-z-khan approved these changes

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes

@JGuinegagne JGuinegagne Awaiting requested review from JGuinegagne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evakravi @codecov-commenter @sagemaker-bot @JGuinegagne @ahsan-z-khan @mufaddal-rohawala