Skip to content

Wrong quotes used in estimator.py and model.py #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sermolin opened this issue Dec 14, 2018 · 3 comments
Closed

Wrong quotes used in estimator.py and model.py #557

sermolin opened this issue Dec 14, 2018 · 3 comments
Labels
status: pending release The fix have been merged but not yet released to PyPI type: documentation

Comments

@sermolin
Copy link
Contributor

Please fill out the form below.

System Information

https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/estimator.py#L249
https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/model.py#L162

Describe the problem

The quotes around 'data', 'var1', 'var2' are incorrect. they should be of " ' " type. Instead they are of " ` " type.
Eg: the line from https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/estimator.py#L249 below.
dictionary form, for example: {‘data’:[1,3,1024,1024]}, or {‘var1’: [1,1,28,28], ‘var2’:[1,1,28,28]}

Minimal repro / logs

N/A

  • Exact command to reproduce:
    N/A
@sermolin
Copy link
Contributor Author

SageMaker Engineering team, please, provide ETA on the fix.

@ChoiByungWook ChoiByungWook mentioned this issue Dec 15, 2018
4 tasks
@ChoiByungWook
Copy link
Contributor

Hello,

Thank you for bringing this to our attention.

I have put out a PR with the corrections here: #562

SageMaker is open source and always open to suggestions and contributions!

Thanks!

@ChoiByungWook ChoiByungWook added status: pending release The fix have been merged but not yet released to PyPI type: documentation labels Dec 15, 2018
@ChoiByungWook
Copy link
Contributor

The PR has been merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending release The fix have been merged but not yet released to PyPI type: documentation
Projects
None yet
Development

No branches or pull requests

2 participants