-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Pipeline paramaters validation for Local mode #4016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @patrick-239, thanks for reaching out! Could you share us the complete error log trace for further investigation. Asking because the error was thrown from |
We have the following validation for json get input in local mode to replicate the behavior in API but seems we miss one for the ParameterString
Update: However, when defining the pipeline, the ParameterString's default value allows an empty string and it won't raise error if the parameter string value is not overridden when starting a pipeline execution. Thus, to make local mode behavior consistent with the cloud, we should add the ParameterString's value validation in execution time (i.e. when starting an execution). |
Describe the bug
In local mode it is possible to pass empty SM pipeline parameter (ParameterString type) when calling the StartPipelineExecution operation, but the same code will rise an exception when launched on cloud: "botocore.exceptions.ClientError: An error occurred (ValidationException) when calling the StartPipelineExecution operation: [string "" is too short (length: 0, required minimum: 1)]". It is hard to develop a code locally when same methods have a different behavior in a cloud.
To reproduce
Launch SM pipeline with an empty parameter in a cloud. Repeat same with local mode.
Expected behavior
Both mode (local and cloud) raise an error or allow to use empty parameters.
Screenshots or logs
If applicable, add screenshots or logs to help explain your problem.
System information
A description of your system. Please provide:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: