Use logger and remove print statements #3938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

anjali-chadha opened this issue Jun 16, 2023 · 1 comment

Assignees

anjali-chadha commented Jun 16, 2023

Describe the feature you'd like
Request to convert print statements to logger. This conversion will provide better control over the logs in the application.
Eg: https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/fw_utils.py#L475-L477

There was a previous pull request (PR #3591) that addressed this issue, but some print statements still exist in the codebase.

martinRenou self-assigned this

martinRenou mentioned this issue

change Using logging instead of prints #4133

Merged

9 tasks

Contributor

akrishna1995 commented Dec 21, 2023

PR has been merged : #4133. Feel free to reopen if you have any issues - Thank you

akrishna1995 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment