Skip to content

Incorrect callable function signatures #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehsanmok opened this issue Aug 5, 2020 · 2 comments
Closed

Incorrect callable function signatures #1814

ehsanmok opened this issue Aug 5, 2020 · 2 comments

Comments

@ehsanmok
Copy link

ehsanmok commented Aug 5, 2020

Across the SDK in different places, the use of typing callable is wrong if it was meant to use Callable. For example, here predictor_cls signature is defined as callable[string, sagemaker.session.Session] and was used like this. If normal Callable was meant (which should be unless specified otherwise) then the last type is the returnType so it should be corrected as something like Callable[[string, sagemaker.session.Session], Any].

@chuyang-deng
Copy link
Contributor

Hi @ehsanmok,

Thanks for submitting the issue. The signature is in docstrings and if you are interested in contributing to the repo, please feel free to do so.

@pintaoz-aws
Copy link
Contributor

Fixed by #5035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants