Skip to content

Create new resources each time with deploy() and transformer() #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
laurenyu opened this issue May 7, 2020 · 0 comments
Closed

Create new resources each time with deploy() and transformer() #1470

laurenyu opened this issue May 7, 2020 · 0 comments
Assignees
Milestone

Comments

@laurenyu
Copy link
Contributor

laurenyu commented May 7, 2020

Is your feature request related to a problem? Please describe.
We’ve had a handful of reports around old models and endpoint configs getting reused even though the customer wanted to deploy to a new instance type (e.g. #987). In addition, simply retrying a deploy() call fails if there are leftover resources from a failed deployment. While this can be handled with currently by specifying update_endpoint=True and/or providing a new endpoint name, this workflow is hard to discover and a little clunky.

Describe the solution you'd like
Let's flip the default to be creating new resources with new generated names each time. This should support the following:

estimator.deploy(1, "ml.p3.16xlarge")

# user runs into account limit, so tries a smaller instance type
estimator.deploy(1, "ml.p3.2xlarge")

The update_endpoint parameter becomes needed only for when a user specifically wants to update an existing endpoint. We can move this logic of updating existing model and endpoint resources to the model and predictor classes, respectively.

Describe alternatives you've considered
There are some alternative proposals in #987.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants