Skip to content

Commit f4d3aca

Browse files
author
Dewen Qi
committed
fix: Fix exp name mixed case issue
1 parent dec014c commit f4d3aca

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/sagemaker/experiments/run.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,9 @@ def _extract_run_name_from_tc_name(trial_component_name: str, experiment_name: s
633633
Returns:
634634
str: The name of the Run object supplied by a user.
635635
"""
636-
return trial_component_name.replace("{}{}".format(experiment_name, DELIMITER), "", 1)
636+
return trial_component_name.replace(
637+
("{}{}".format(experiment_name, DELIMITER)).lower(), "", 1
638+
)
637639

638640
@staticmethod
639641
def _append_run_tc_label_to_tags(tags: Optional[List[Dict[str, str]]] = None) -> list:

tests/integ/sagemaker/experiments/conftest.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
from tests.integ.sagemaker.experiments.helpers import name, names
3232

3333
TAGS = [{"Key": "some-key", "Value": "some-value"}]
34-
EXP_NAME_BASE_IN_LOCAL = "job-exp-in-local"
34+
EXP_NAME_BASE_IN_LOCAL = "Job-Exp-in-Local"
3535
RUN_NAME_IN_LOCAL = "job-run-in-local"
3636

3737

tests/integ/sagemaker/experiments/test_run.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def verify_load_run():
7777
assert run2.run_name == run1_name
7878
assert (
7979
run2._trial_component.trial_component_name
80-
== f"{exp_name}{DELIMITER}{run1_name}"
80+
== f"{exp_name}{DELIMITER}{run1_name}".lower()
8181
)
8282
_check_run_from_local_end_result(
8383
sagemaker_session=sagemaker_session, tc=run2._trial_component

0 commit comments

Comments
 (0)