change: add p4d to smdataparallel supported instances (#538)

Author: ChaiBapchya

src/sagemaker/fw_utils.py

@@ -50,7 +50,12 @@
 
 DEBUGGER_UNSUPPORTED_REGIONS = ("us-iso-east-1",)
 SINGLE_GPU_INSTANCE_TYPES = ("ml.p2.xlarge", "ml.p3.2xlarge")
-SM_DATAPARALLEL_SUPPORTED_INSTANCE_TYPES = ("ml.p3.16xlarge", "ml.p3dn.24xlarge", "local_gpu")
+SM_DATAPARALLEL_SUPPORTED_INSTANCE_TYPES = (
+    "ml.p3.16xlarge",
+    "ml.p3dn.24xlarge",
+    "ml.p4d.24xlarge",
+    "local_gpu",
+)
 SM_DATAPARALLEL_SUPPORTED_FRAMEWORK_VERSIONS = {
     "tensorflow": ["2.3.0", "2.3.1"],
     "pytorch": ["1.6.0"],

tests/unit/test_fw_utils.py

@@ -552,7 +552,7 @@ def test_validate_version_or_image_args_raises():
 def test_validate_smdistributed_not_raises():
     smdataparallel_enabled = {"smdistributed": {"dataparallel": {"enabled": True}}}
     smdataparallel_disabled = {"smdistributed": {"dataparallel": {"enabled": False}}}
-    instance_types = ["ml.p3.16xlarge", "ml.p3dn.24xlarge"]
+    instance_types = list(fw_utils.SM_DATAPARALLEL_SUPPORTED_INSTANCE_TYPES)
 
     good_args = [
         (smdataparallel_enabled, "custom-container"),