Skip to content

Commit dae4e18

Browse files
author
Chuyang Deng
committed
Rebase to exclude model linkage from this PR.
1 parent e527afe commit dae4e18

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

CHANGELOG.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ CHANGELOG
88
* doc-fix: update information about saving models in the MXNet README
99
* doc-fix: change ReadTheDocs links from latest to stable
1010
* doc-fix: add ``transform_fn`` information and fix ``input_fn`` signature in the MXNet README
11-
* feature: Support for predictor class to delete endpoint configuration by default when calling ``delete_endpoint()``
12-
* feature: Support for model class to delete SageMaker model
13-
* feature: Support for transformer to delete Sagemaker model
11+
* feature: Support for ``Predictor`` to delete endpoint configuration by default when calling ``delete_endpoint()``
12+
* feature: Support for ``model`` to delete SageMaker model
13+
* feature: Support for ``Transformer`` to delete SageMaker model
1414

1515
1.18.2
1616
======

src/sagemaker/model.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -303,13 +303,14 @@ def transformer(self, instance_count, instance_type, strategy=None, assemble_wit
303303
volume_kms_key=volume_kms_key, sagemaker_session=self.sagemaker_session)
304304

305305
def delete_model(self):
306-
"""Delete an Amazon SageMaker ``Model``.
306+
"""Delete an Amazon SageMaker Model.
307307
308-
Raises: ValueError if model is not deployed yet.
308+
Raises:
309+
ValueError: if the model is not created yet.
309310
310311
"""
311312
if self.name is None:
312-
raise ValueError('The SageMaker model must be deployed first before attempting to delete.')
313+
raise ValueError('The SageMaker model must be created first before attempting to delete.')
313314
self.sagemaker_session.delete_model(self.name)
314315

315316

src/sagemaker/session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -790,7 +790,7 @@ def delete_endpoint_config(self, endpoint_config_name):
790790
self.sagemaker_client.delete_endpoint_config(EndpointConfigName=endpoint_config_name)
791791

792792
def delete_model(self, model_name):
793-
"""Delete an Amazon SageMaker ``Model``.
793+
"""Delete an Amazon SageMaker Model.
794794
795795
Args:
796796
model_name (str): Name of the Amazon SageMaker model to delete.

tests/unit/test_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,5 +349,5 @@ def test_model_delete_model(sagemaker_session, tmpdir):
349349

350350
def test_delete_non_deployed_model(sagemaker_session):
351351
model = DummyFrameworkModel(sagemaker_session)
352-
with pytest.raises(ValueError, match='The SageMaker model must be deployed first before attempting to delete.'):
352+
with pytest.raises(ValueError, match='The SageMaker model must be created first before attempting to delete.'):
353353
model.delete_model()

0 commit comments

Comments
 (0)