Skip to content

Commit dae28cc

Browse files
committed
fix: improve reliability of Run integration test
1 parent c02d74b commit dae28cc

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

ada.log

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"_aws" : {"Timestamp":1679517110000,"CloudWatchMetrics":[{"Namespace":"toolbox-python-migration-tools","Dimensions":[[],["Platform"],["Channel"],["Command"],["Version"],["Platform","Channel"],["Command","Channel"],["Version","Channel"],["ToolName","SubCommand"]],"Metrics":[{"Name":"Success","Unit":"Count"}]}]},"Success" : 1,"Version" : "1.0.1880.0","ToolName" : "","SubCommand" : "update","Platform" : "macOS-amd64","Channel" : "stable","Command" : "flake8","Channel" : "stable","Arch" : "amd64","Command" : "flake8","User" : "danabens","InvocationId" : "1-641b65b6-3130261744f6c82e8f971c80","Os" : "osx","Platform" : "macOS-amd64","Hostname" : "88665a415b08.ant.amazon.com","Version" : "1.0.1880.0"}

tests/integ/sagemaker/experiments/test_run.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import datetime
1616
import json
1717
import os
18+
import time
1819

1920
import pytest
2021

@@ -245,6 +246,12 @@ def test_run_from_local_and_train_job_and_all_exp_cfg_match(
245246
sagemaker_session=sagemaker_session,
246247
)
247248

249+
# the above estimator has wait=True but the job TC could still be receiving updates
250+
# after wait is complete resulting in run TC being updated, then when the above with
251+
# statement is exited another update trial component call is made _sometimes_
252+
# resulting in a ConflictException
253+
time.sleep(3)
254+
248255
_check_tc_status_when_exiting(
249256
trial_component_name=run._trial_component.trial_component_name,
250257
init_start_time=init_start_time,

0 commit comments

Comments
 (0)