Skip to content

Commit d3c614f

Browse files
author
Chuyang Deng
committed
update docs and test for predictor
1 parent c055924 commit d3c614f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/sagemaker/predictor.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@ def _delete_endpoint_config(self):
113113
self.sagemaker_session.delete_endpoint_config(self._endpoint_config_name)
114114

115115
def delete_endpoint(self, delete_endpoint_config=True):
116-
"""Delete the Amazon SageMaker endpoint and endpoint configuration backing this predictor.
116+
"""Delete the Amazon SageMaker endpoint backing this predictor. Also delete the endpoint configuration attached
117+
to it if delete_endpoint_config is True.
117118
118119
Args:
119120
delete_endpoint_config (bool, optional): Flag to indicate whether to delete endpoint configuration together

tests/unit/test_predictor.py

+4
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,8 @@ def json_sagemaker_session():
389389
ims = Mock(name='sagemaker_session')
390390
ims.default_bucket = Mock(name='default_bucket', return_value=BUCKET_NAME)
391391
ims.sagemaker_runtime_client = Mock(name='sagemaker_runtime')
392+
ims.sagemaker_client.describe_endpoint = Mock(return_value=ENDPOINT_DESC)
393+
ims.sagemaker_client.describe_endpoint_config = Mock(return_value=ENDPOINT_CONFIG_DESC)
392394

393395
ims.sagemaker_client.describe_endpoint = Mock(return_value=ENDPOINT_DESC)
394396
ims.sagemaker_client.describe_endpoint_config = Mock(return_value=ENDPOINT_CONFIG_DESC)
@@ -430,6 +432,8 @@ def ret_csv_sagemaker_session():
430432
ims = Mock(name='sagemaker_session')
431433
ims.default_bucket = Mock(name='default_bucket', return_value=BUCKET_NAME)
432434
ims.sagemaker_runtime_client = Mock(name='sagemaker_runtime')
435+
ims.sagemaker_client.describe_endpoint = Mock(return_value=ENDPOINT_DESC)
436+
ims.sagemaker_client.describe_endpoint_config = Mock(return_value=ENDPOINT_CONFIG_DESC)
433437

434438
ims.sagemaker_client.describe_endpoint = Mock(return_value=ENDPOINT_DESC)
435439
ims.sagemaker_client.describe_endpoint_config = Mock(return_value=ENDPOINT_CONFIG_DESC)

0 commit comments

Comments
 (0)