Skip to content

Commit d37df68

Browse files
committed
Fix existing test failures
1 parent 07443bb commit d37df68

File tree

2 files changed

+16
-18
lines changed

2 files changed

+16
-18
lines changed

src/sagemaker/lambda_helper.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,9 @@ def update(self):
153153
try:
154154
if self.script is not None:
155155
response = lambda_client.update_function_code(
156-
FunctionName=self.function_name, ZipFile=_zip_lambda_code(self.script)
156+
FunctionName=self.function_name,
157+
ZipFile=_zip_lambda_code(self.script),
158+
Architectures=self.architectures,
157159
)
158160
else:
159161
response = lambda_client.update_function_code(
@@ -165,7 +167,7 @@ def update(self):
165167
zipped_code_dir=self.zipped_code_dir,
166168
s3_bucket=self.s3_bucket,
167169
),
168-
Architectures=self.architectures
170+
Architectures=self.architectures,
169171
)
170172
return response
171173
except ClientError as e:

tests/unit/test_lambda_helper.py

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,9 @@ def test_create_lambda_happycase1(sagemaker_session):
175175
Code=code,
176176
Timeout=120,
177177
MemorySize=128,
178+
Architectures=None,
179+
VpcConfig=None,
180+
Environment=None,
178181
)
179182

180183

@@ -200,6 +203,9 @@ def test_create_lambda_happycase2(sagemaker_session):
200203
Code=code,
201204
Timeout=120,
202205
MemorySize=128,
206+
Architectures=None,
207+
VpcConfig=None,
208+
Environment=None,
203209
)
204210

205211

@@ -252,7 +258,7 @@ def test_update_lambda_happycase1(sagemaker_session):
252258
lambda_obj.update()
253259

254260
sagemaker_session.lambda_client.update_function_code.assert_called_with(
255-
FunctionName=FUNCTION_NAME, ZipFile=ZIPPED_CODE
261+
FunctionName=FUNCTION_NAME, ZipFile=ZIPPED_CODE, Architectures=None,
256262
)
257263

258264

@@ -270,7 +276,7 @@ def test_update_lambda_happycase2(sagemaker_session):
270276
lambda_obj.update()
271277

272278
sagemaker_session.lambda_client.update_function_code.assert_called_with(
273-
FunctionName=LAMBDA_ARN, S3Bucket=S3_BUCKET, S3Key=S3_KEY
279+
FunctionName=LAMBDA_ARN, S3Bucket=S3_BUCKET, S3Key=S3_KEY, Architectures=None,
274280
)
275281

276282

@@ -302,12 +308,6 @@ def test_upsert_lambda_happycase1(sagemaker_session):
302308
script=SCRIPT,
303309
handler=HANDLER,
304310
session=sagemaker_session,
305-
architectures=["x86_64"],
306-
environment={"Name": "my-test-lambda"},
307-
vpc_config={
308-
"SubnetIds": ["test-subnet-1"],
309-
"SecurityGroupIds": ["sec-group-1"]
310-
}
311311
)
312312

313313
code = {"ZipFile": ZIPPED_CODE}
@@ -321,12 +321,9 @@ def test_upsert_lambda_happycase1(sagemaker_session):
321321
Code=code,
322322
Timeout=120,
323323
MemorySize=128,
324-
Architectures=["x86_64"],
325-
Environment={"Name": "my-test-lambda"},
326-
VpcConfig={
327-
"SubnetIds": ["test-subnet-1"],
328-
"SecurityGroupIds": ["sec-group-1"]
329-
}
324+
Architectures=None,
325+
VpcConfig=None,
326+
Environment=None,
330327
)
331328

332329

@@ -338,7 +335,6 @@ def test_upsert_lambda_happycase2(sagemaker_session):
338335
script=SCRIPT,
339336
handler=HANDLER,
340337
session=sagemaker_session,
341-
architectures=["x86_64"]
342338
)
343339

344340
sagemaker_session.lambda_client.create_function.side_effect = ClientError(
@@ -349,7 +345,7 @@ def test_upsert_lambda_happycase2(sagemaker_session):
349345
lambda_obj.upsert()
350346

351347
sagemaker_session.lambda_client.update_function_code.assert_called_once_with(
352-
FunctionName=FUNCTION_NAME, ZipFile=ZIPPED_CODE, Architectures=["x86_64"]
348+
FunctionName=FUNCTION_NAME, ZipFile=ZIPPED_CODE, Architectures=None
353349
)
354350

355351

0 commit comments

Comments
 (0)