Skip to content

Commit c5b594b

Browse files
committed
deprecation: Remove explicit partitions key requirement on pysdk side.
Clean up API for SMP v2. `partitions` key will still be checked on library side for SMP v1. Remove related test checking that error is thrown if partitions is not passed.
1 parent 4c0fb3c commit c5b594b

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

src/sagemaker/fw_utils.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -323,9 +323,6 @@ def validate_mp_config(config):
323323
ValueError: If any of the keys have incorrect values.
324324
"""
325325

326-
if "partitions" not in config:
327-
raise ValueError("'partitions' is a required parameter.")
328-
329326
def validate_positive(key):
330327
try:
331328
if not isinstance(config[key], int) or config[key] < 1:

tests/unit/test_fw_utils.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -135,12 +135,6 @@ def test_tar_and_upload_dir_s3_without_kms_with_overridden_settings(utils, sagem
135135
obj.upload_file.assert_called_with(utils.create_tar_file(), ExtraArgs=None)
136136

137137

138-
def test_mp_config_partition_exists():
139-
mp_parameters = {}
140-
with pytest.raises(ValueError):
141-
fw_utils.validate_mp_config(mp_parameters)
142-
143-
144138
@pytest.mark.parametrize(
145139
"pipeline, placement_strategy, optimize, trace_device",
146140
[

0 commit comments

Comments
 (0)