Skip to content

Commit c16bb99

Browse files
fix: Minor fixes
1 parent 2133ce7 commit c16bb99

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

.githooks/pre-push

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ start_time=`date +%s`
1212
tox -e sphinx,doc8 --parallel all
1313
./ci-scripts/displaytime.sh 'sphinx,doc8' $start_time
1414
start_time=`date +%s`
15-
tox -e py36,py37,py38 --parallel all -- tests/unit
16-
./ci-scripts/displaytime.sh 'py36,py37,py38 unit' $start_time
15+
tox -e py36,py37,py38,py39 --parallel all -- tests/unit
16+
./ci-scripts/displaytime.sh 'py36,py37,py38,py39 unit' $start_time

tests/unit/test_image.py

+15-5
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,8 @@
7474
"sagemaker_submit_directory": json.dumps("file:///tmp/code"),
7575
}
7676

77+
ENVIRONMENT = {"MYVAR": "HELLO_WORLD"}
78+
7779

7880
@pytest.fixture()
7981
def sagemaker_session():
@@ -352,7 +354,7 @@ def test_train(
352354
"local", instance_count, image, sagemaker_session=sagemaker_session
353355
)
354356
sagemaker_container.train(
355-
INPUT_DATA_CONFIG, OUTPUT_DATA_CONFIG, HYPERPARAMETERS, TRAINING_JOB_NAME
357+
INPUT_DATA_CONFIG, OUTPUT_DATA_CONFIG, HYPERPARAMETERS, ENVIRONMENT, TRAINING_JOB_NAME
356358
)
357359

358360
docker_compose_file = os.path.join(
@@ -415,7 +417,7 @@ def test_train_with_hyperparameters_without_job_name(
415417
"local", instance_count, image, sagemaker_session=sagemaker_session
416418
)
417419
sagemaker_container.train(
418-
INPUT_DATA_CONFIG, OUTPUT_DATA_CONFIG, HYPERPARAMETERS, TRAINING_JOB_NAME
420+
INPUT_DATA_CONFIG, OUTPUT_DATA_CONFIG, HYPERPARAMETERS, ENVIRONMENT, TRAINING_JOB_NAME
419421
)
420422

421423
docker_compose_file = os.path.join(
@@ -456,7 +458,11 @@ def test_train_error(
456458

457459
with pytest.raises(RuntimeError) as e:
458460
sagemaker_container.train(
459-
INPUT_DATA_CONFIG, OUTPUT_DATA_CONFIG, HYPERPARAMETERS, TRAINING_JOB_NAME
461+
INPUT_DATA_CONFIG,
462+
OUTPUT_DATA_CONFIG,
463+
HYPERPARAMETERS,
464+
ENVIRONMENT,
465+
TRAINING_JOB_NAME,
460466
)
461467

462468
assert "this is expected" in str(e)
@@ -486,7 +492,11 @@ def test_train_local_code(get_data_source_instance, tmpdir, sagemaker_session):
486492
)
487493

488494
sagemaker_container.train(
489-
INPUT_DATA_CONFIG, OUTPUT_DATA_CONFIG, LOCAL_CODE_HYPERPARAMETERS, TRAINING_JOB_NAME
495+
INPUT_DATA_CONFIG,
496+
OUTPUT_DATA_CONFIG,
497+
LOCAL_CODE_HYPERPARAMETERS,
498+
ENVIRONMENT,
499+
TRAINING_JOB_NAME,
490500
)
491501

492502
docker_compose_file = os.path.join(
@@ -538,7 +548,7 @@ def test_train_local_intermediate_output(get_data_source_instance, tmpdir, sagem
538548
hyperparameters = {"sagemaker_s3_output": output_path}
539549

540550
sagemaker_container.train(
541-
INPUT_DATA_CONFIG, output_data_config, hyperparameters, TRAINING_JOB_NAME
551+
INPUT_DATA_CONFIG, output_data_config, hyperparameters, ENVIRONMENT, TRAINING_JOB_NAME
542552
)
543553

544554
docker_compose_file = os.path.join(

0 commit comments

Comments
 (0)