Skip to content

Commit bd43571

Browse files
staubhpPayton Staubshreyapanditahsan-z-khan
authored
Use correct boto model name for RegisterModelStep properties (#2543)
Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Ahsan Khan <[email protected]>
1 parent 2efaefd commit bd43571

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

src/sagemaker/workflow/_utils.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -288,9 +288,7 @@ def __init__(
288288
self.kwargs = kwargs
289289
self.container_def_list = container_def_list
290290

291-
self._properties = Properties(
292-
path=f"Steps.{name}", shape_name="DescribeModelPackageResponse"
293-
)
291+
self._properties = Properties(path=f"Steps.{name}", shape_name="DescribeModelPackageOutput")
294292

295293
@property
296294
def arguments(self) -> RequestType:
@@ -366,5 +364,5 @@ def arguments(self) -> RequestType:
366364

367365
@property
368366
def properties(self):
369-
"""A Properties object representing the DescribeTrainingJobResponse data model."""
367+
"""A Properties object representing the DescribeModelPackageOutput data model."""
370368
return self._properties

tests/unit/sagemaker/workflow/test_properties.py

+11
Original file line numberDiff line numberDiff line change
@@ -67,3 +67,14 @@ def test_properties_tuning_job():
6767
assert prop.TrainingJobSummaries[0].TrainingJobName.expr == {
6868
"Get": "Steps.MyStep.TrainingJobSummaries[0].TrainingJobName"
6969
}
70+
71+
72+
def test_properties_describe_model_package_output():
73+
prop = Properties("Steps.MyStep", "DescribeModelPackageOutput")
74+
some_prop_names = ["ModelPackageName", "ModelPackageGroupName", "ModelPackageArn"]
75+
for name in some_prop_names:
76+
assert name in prop.__dict__.keys()
77+
assert prop.ModelPackageName.expr == {"Get": "Steps.MyStep.ModelPackageName"}
78+
assert prop.ValidationSpecification.ValidationRole.expr == {
79+
"Get": "Steps.MyStep.ValidationSpecification.ValidationRole"
80+
}

0 commit comments

Comments
 (0)