Print failed model delete names in error message.

Author: Chuyang Deng

src/sagemaker/predictor.py

@@ -133,14 +133,17 @@ def delete_model(self):
 
         """
         request_failed = False
+        failed_models = []
         for model_name in self._model_names:
             try:
                 self.sagemaker_session.delete_model(model_name)
             except Exception:  # pylint: disable=broad-except
                 request_failed = True
+                failed_models.append(model_name)
 
         if request_failed:
-            raise Exception('One or more models cannot be deleted, please retry.')
+            raise Exception('One or more models cannot be deleted, please retry. \n'
+                            'Failed models: {}'.format(', '.join(failed_models)))
 
     def _get_endpoint_config_name(self):
         endpoint_desc = self.sagemaker_session.sagemaker_client.describe_endpoint(EndpointName=self.endpoint)

tests/unit/test_predictor.py

@@ -503,11 +503,11 @@ def test_delete_model():
 
 def test_delete_model_fail():
     sagemaker_session = empty_sagemaker_session()
-    sagemaker_session.sagemaker_client.delete_model = Mock(side_effect='Could not find model.')
+    sagemaker_session.sagemaker_client.delete_model = Mock(side_effect=Exception('Could not find model.'))
     expected_error_message = 'One or more models cannot be deleted, please retry.'
 
     predictor = RealTimePredictor(ENDPOINT, sagemaker_session=sagemaker_session)
 
     with pytest.raises(Exception) as exception:
         predictor.delete_model()
-        assert str(exception.val) == expected_error_message
+        assert expected_error_message in str(exception.val)