Skip to content

Commit ad61d98

Browse files
committed
address PR comment
1 parent 0ab23ca commit ad61d98

File tree

2 files changed

+19
-3
lines changed

2 files changed

+19
-3
lines changed

src/sagemaker/image_uris.py

+7-2
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,14 @@ def _validate_version_and_set_if_needed(version, config, framework):
101101
available_versions = list(config["versions"].keys())
102102

103103
if len(available_versions) == 1:
104-
logger.info(
105-
"Defaulting to only available framework/algorithm version: %s", available_versions[0]
104+
log_message = "Defaulting to the only supported framework/algorithm version: {}.".format(
105+
available_versions[0]
106106
)
107+
if version and version != available_versions[0]:
108+
logger.warning("%s Ignoring framework/algorithm version: %s.", log_message, version)
109+
elif not version:
110+
logger.info(log_message)
111+
107112
return available_versions[0]
108113

109114
available_versions += list(config.get("version_aliases", {}).keys())

tests/unit/sagemaker/image_uris/test_retrieve.py

+12-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def test_retrieve_aliased_version(config_for_framework):
129129

130130

131131
@patch("sagemaker.image_uris.config_for_framework")
132-
def test_retrieve_default_version_if_possible(config_for_framework):
132+
def test_retrieve_default_version_if_possible(config_for_framework, caplog):
133133
config = copy.deepcopy(BASE_CONFIG)
134134
del config["versions"]["1.1.0"]
135135
config_for_framework.return_value = config
@@ -143,6 +143,17 @@ def test_retrieve_default_version_if_possible(config_for_framework):
143143
)
144144
assert "123412341234.dkr.ecr.us-west-2.amazonaws.com/dummy:1.0.0-cpu-py3" == uri
145145

146+
uri = image_uris.retrieve(
147+
framework="useless-string",
148+
version="invalid-version",
149+
py_version="py3",
150+
instance_type="ml.c4.xlarge",
151+
region="us-west-2",
152+
image_scope="training",
153+
)
154+
assert "123412341234.dkr.ecr.us-west-2.amazonaws.com/dummy:1.0.0-cpu-py3" == uri
155+
assert "Ignoring framework/algorithm version: invalid-version." in caplog.text
156+
146157

147158
@patch("sagemaker.image_uris.config_for_framework", return_value=BASE_CONFIG)
148159
def test_retrieve_unsupported_version(config_for_framework):

0 commit comments

Comments
 (0)