Skip to content

Commit a013b71

Browse files
committed
Minor fix unit tests
1 parent 77848f2 commit a013b71

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

src/sagemaker/pytorch/estimator.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,7 @@ def _pytorch_distribution_configuration(self, distribution):
241241
dict containing Pytorch DDP config
242242
"""
243243
distribution_config = {}
244+
pytorch_ddp_enabled = False
244245
if "pytorchddp" in distribution:
245246
pytorch_ddp_enabled = distribution.get("pytorchddp").get("enabled", False)
246247

tests/integ/test_pytorchddp.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
)
3434
def test_pytorchddp_pt_mnist(
3535
sagemaker_session,
36-
pytorch_training_latest_version,
37-
pytorch_training_latest_py_version,
36+
pytorch_ddp_framework_version,
37+
pytorch_ddp_py_version,
3838
):
3939
job_name = sagemaker.utils.unique_name_from_base("pt-pytorch-ddp")
4040
estimator = PyTorch(
@@ -44,8 +44,8 @@ def test_pytorchddp_pt_mnist(
4444
instance_count=2,
4545
instance_type="ml.p3.16xlarge",
4646
sagemaker_session=sagemaker_session,
47-
framework_version=pytorch_training_latest_version,
48-
py_version=pytorch_training_latest_py_version,
47+
framework_version=pytorch_ddp_framework_version,
48+
py_version=pytorch_ddp_py_version,
4949
distribution={"pytorchddp": {"enabled": True}},
5050
)
5151

tests/unit/test_pytorch.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -765,6 +765,8 @@ def test_register_pytorch_model_auto_infer_framework(
765765
sagemaker_session.create_model_package_from_containers.assert_called_with(
766766
**expected_create_model_package_request
767767
)
768+
769+
768770
def test_pytorch_ddp_distribution_configuration(
769771
sagemaker_session, pytorch_ddp_framework_version, pytorch_ddp_py_version
770772
):

0 commit comments

Comments
 (0)