feature: Add business details and hyper parameters fields and update test_model_card.py

Haonian Wang · Haonian Wang · commit 9e79a4defcad · 2023-02-08T16:33:52.000-08:00
diff --git a/src/sagemaker/model_card/model_card.py b/src/sagemaker/model_card/model_card.py
@@ -493,7 +493,6 @@ def _create_training_details(training_job_data: dict, cls: "TrainingDetails", **
                 ]
                 if "FinalMetricDataList" in training_job_data
                 else [],
-                # "hyper_parameters": print(training_job_data["HyperParameters"]),
                 "hyper_parameters": [
                     HyperParameter(key, value)
                     for key, value in training_job_data["HyperParameters"].items()
diff --git a/tests/unit/test_model_card.py b/tests/unit/test_model_card.py
@@ -1090,9 +1090,9 @@ def test_training_details_autodiscovery_from_model_overview_autopilot(
         model_overview=model_overview_example, sagemaker_session=session
     )
 
-    # There are 0 required keys in training_metrics field in SEARCH_TRAINING_JOB_AUTOPILOT_EXAMPLE has
+    # MetricDefinitions is empty
     assert len(training_details.training_job_details.training_metrics) == 0
-    # There are 3 required keys in hyper_parameters field in SEARCH_TRAINING_JOB_AUTOPILOT_EXAMPLE has
+    # HyperParameters have 3 keys
     assert len(training_details.training_job_details.hyper_parameters) == 3
 
 

Original file line number	Diff line number	Diff line change
`@@ -493,7 +493,6 @@ def _create_training_details(training_job_data: dict, cls: "TrainingDetails", **`
`493`	`493`	`]`
`494`	`494`	`if "FinalMetricDataList" in training_job_data`
`495`	`495`	`else [],`
`496`		`- # "hyper_parameters": print(training_job_data["HyperParameters"]),`
`497`	`496`	`"hyper_parameters": [`
`498`	`497`	`HyperParameter(key, value)`
`499`	`498`	`for key, value in training_job_data["HyperParameters"].items()`
Original file line number	Diff line number	Diff line change
`@@ -1090,9 +1090,9 @@ def test_training_details_autodiscovery_from_model_overview_autopilot(`
`1090`	`1090`	`model_overview=model_overview_example, sagemaker_session=session`
`1091`	`1091`	`)`
`1092`	`1092`
`1093`		`- # There are 0 required keys in training_metrics field in SEARCH_TRAINING_JOB_AUTOPILOT_EXAMPLE has`
	`1093`	`+ # MetricDefinitions is empty`
`1094`	`1094`	`assert len(training_details.training_job_details.training_metrics) == 0`
`1095`		`- # There are 3 required keys in hyper_parameters field in SEARCH_TRAINING_JOB_AUTOPILOT_EXAMPLE has`
	`1095`	`+ # HyperParameters have 3 keys`
`1096`	`1096`	`assert len(training_details.training_job_details.hyper_parameters) == 3`
`1097`	`1097`
`1098`	`1098`