Skip to content

Commit 9b437be

Browse files
Doc: updated pr template to check backward compatibility (#2655)
Co-authored-by: Navin Soni <[email protected]>
1 parent f7a57c2 commit 9b437be

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+2
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,15 @@ _Put an `x` in the boxes that apply. You can also fill these out after creating
1111
#### General
1212

1313
- [ ] I have read the [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md) doc
14+
- [ ] I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
1415
- [ ] I used the commit message format described in [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md#committing-your-change)
1516
- [ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
1617
- [ ] I have updated any necessary documentation, including [READMEs](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) and [API docs](https://github.com/aws/sagemaker-python-sdk/tree/master/doc) (if appropriate)
1718

1819
#### Tests
1920

2021
- [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
22+
- [ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
2123
- [ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
2224
- [ ] I have used [`unique_name_from_base`](https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/utils.py#L77) to create resource names in integ tests (if appropriate)
2325

0 commit comments

Comments
 (0)