Skip to content

Commit 9061757

Browse files
ChoiByungWookjesterhazy
authored andcommitted
enable ei integ tests (#527)
1 parent 0bb9863 commit 9061757

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

tests/conftest.py

+10
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,11 @@ def mxnet_version(request):
9595
return request.param
9696

9797

98+
@pytest.fixture(scope='module', params=['1.3', '1.3.0'])
99+
def ei_mxnet_version(request):
100+
return request.param
101+
102+
98103
@pytest.fixture(scope='module', params=['0.4', '0.4.0'])
99104
def pytorch_version(request):
100105
return request.param
@@ -112,6 +117,11 @@ def tf_version(request):
112117
return request.param
113118

114119

120+
@pytest.fixture(scope='module', params=['1.11', '1.11.0'])
121+
def ei_tf_version(request):
122+
return request.param
123+
124+
115125
@pytest.fixture(scope='module', params=['0.10.1', '0.10.1', '0.11', '0.11.0'])
116126
def rl_coach_tf_version(request):
117127
return request.param

tests/integ/test_mxnet_train.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,16 +71,16 @@ def test_deploy_model(mxnet_training_job, sagemaker_session):
7171
predictor.predict(data)
7272

7373

74-
@pytest.mark.skip
75-
def test_deploy_model_with_accelerator(mxnet_training_job, sagemaker_session):
74+
def test_deploy_model_with_accelerator(mxnet_training_job, sagemaker_session, ei_mxnet_version):
7675
endpoint_name = 'test-mxnet-deploy-model-ei-{}'.format(sagemaker_timestamp())
7776

7877
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session):
7978
desc = sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=mxnet_training_job)
8079
model_data = desc['ModelArtifacts']['S3ModelArtifacts']
8180
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'mnist.py')
8281
model = MXNetModel(model_data, 'SageMakerRole', entry_point=script_path,
83-
py_version=PYTHON_VERSION, sagemaker_session=sagemaker_session)
82+
framework_version=ei_mxnet_version, py_version=PYTHON_VERSION,
83+
sagemaker_session=sagemaker_session)
8484
predictor = model.deploy(1, 'ml.m4.xlarge', endpoint_name=endpoint_name, accelerator_type='ml.eia1.medium')
8585

8686
data = numpy.zeros(shape=(1, 1, 28, 28))

tests/integ/test_tf.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,8 @@ def test_deploy_model(sagemaker_session, tf_training_job):
7676
assert dict_result == list_result
7777

7878

79-
@pytest.mark.skip
8079
@pytest.mark.skipif(PYTHON_VERSION != 'py2', reason="TensorFlow image supports only python 2.")
81-
def test_deploy_model_with_accelerator(sagemaker_session, tf_training_job):
80+
def test_deploy_model_with_accelerator(sagemaker_session, tf_training_job, ei_tf_version):
8281
endpoint_name = 'test-tf-deploy-model-ei-{}'.format(sagemaker_timestamp())
8382

8483
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session):
@@ -87,7 +86,7 @@ def test_deploy_model_with_accelerator(sagemaker_session, tf_training_job):
8786

8887
script_path = os.path.join(DATA_DIR, 'iris', 'iris-dnn-classifier.py')
8988
model = TensorFlowModel(model_data, 'SageMakerRole', entry_point=script_path,
90-
sagemaker_session=sagemaker_session)
89+
framework_version=ei_tf_version, sagemaker_session=sagemaker_session)
9190

9291
json_predictor = model.deploy(initial_instance_count=1, instance_type='ml.c4.xlarge',
9392
endpoint_name=endpoint_name, accelerator_type='ml.eia1.medium')

0 commit comments

Comments
 (0)