address comments

Author: tejaschumbalkar

src/sagemaker/fw_utils.py

@@ -122,6 +122,7 @@
         "1.11",
         "1.11.0",
         "1.12",
+        "1.12.0",
         "1.12.1",
     ],
 }
@@ -133,6 +134,7 @@
     "1.11",
     "1.11.0",
     "1.12",
+    "1.12.0",
     "1.12.1",
 ]
 

tests/unit/test_fw_utils.py

@@ -863,6 +863,7 @@ def test_validate_smdataparallel_args_not_raises():
         ("ml.p3.16xlarge", "pytorch", "1.10", "py38", smdataparallel_enabled),
         ("ml.p3.16xlarge", "pytorch", "1.11.0", "py38", smdataparallel_enabled),
         ("ml.p3.16xlarge", "pytorch", "1.11", "py38", smdataparallel_enabled),
+        ("ml.p3.16xlarge", "pytorch", "1.12.0", "py38", smdataparallel_enabled),
         ("ml.p3.16xlarge", "pytorch", "1.12.1", "py38", smdataparallel_enabled),
         ("ml.p3.16xlarge", "pytorch", "1.12", "py38", smdataparallel_enabled),
         ("ml.p3.16xlarge", "tensorflow", "2.4.1", "py3", smdataparallel_enabled_custom_mpi),
@@ -881,6 +882,7 @@ def test_validate_smdataparallel_args_not_raises():
         ("ml.p3.16xlarge", "pytorch", "1.9.1", "py38", smdataparallel_enabled_custom_mpi),
         ("ml.p3.16xlarge", "pytorch", "1.10.2", "py38", smdataparallel_enabled_custom_mpi),
         ("ml.p3.16xlarge", "pytorch", "1.11.0", "py38", smdataparallel_enabled_custom_mpi),
+        ("ml.p3.16xlarge", "pytorch", "1.12.0", "py38", smdataparallel_enabled_custom_mpi),
         ("ml.p3.16xlarge", "pytorch", "1.12.1", "py38", smdataparallel_enabled_custom_mpi),
     ]
     for instance_type, framework_name, framework_version, py_version, distribution in good_args:
@@ -916,6 +918,7 @@ def test_validate_pytorchddp_not_raises():
         "1.11",
         "1.11.0",
         "1.12",
+        "1.12.0",
         "1.12.1",
     ]
     for framework_version in pytorchddp_supported_fw_versions: