Skip to content

Commit 86822d2

Browse files
committed
fix: prepare container def accept_eula=False
1 parent 6673e99 commit 86822d2

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/sagemaker/model.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -648,7 +648,9 @@ def prepare_container_def(
648648
self.repacked_model_data or self.model_data,
649649
deploy_env,
650650
image_config=self.image_config,
651-
accept_eula=accept_eula or getattr(self, "accept_eula", None),
651+
accept_eula=accept_eula
652+
if accept_eula is not None
653+
else getattr(self, "accept_eula", None),
652654
)
653655

654656
def is_repack(self) -> bool:

tests/unit/sagemaker/model/test_model.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,21 @@ def test_create_sagemaker_model_with_eula(prepare_container_def, sagemaker_sessi
337337
)
338338

339339

340+
@patch("sagemaker.model.Model.prepare_container_def")
341+
def test_create_sagemaker_model_with_eula_false(prepare_container_def, sagemaker_session):
342+
model = Model(MODEL_IMAGE, MODEL_DATA, name=MODEL_NAME, sagemaker_session=sagemaker_session)
343+
344+
accelerator_type = "ml.eia.medium"
345+
model.create(INSTANCE_TYPE, accelerator_type=accelerator_type, accept_eula=False)
346+
347+
prepare_container_def.assert_called_with(
348+
INSTANCE_TYPE,
349+
accelerator_type=accelerator_type,
350+
serverless_inference_config=None,
351+
accept_eula=False,
352+
)
353+
354+
340355
@patch("sagemaker.model.Model.prepare_container_def")
341356
def test_create_sagemaker_model_tags(prepare_container_def, sagemaker_session):
342357
container_def = {"Image": MODEL_IMAGE, "Environment": {}, "ModelDataUrl": MODEL_DATA}

0 commit comments

Comments
 (0)