Skip to content

Commit 84e88c0

Browse files
committed
chore: address PR comments
1 parent 84969d9 commit 84e88c0

File tree

2 files changed

+20
-7
lines changed

2 files changed

+20
-7
lines changed

src/sagemaker/utils.py

+6-3
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
from sagemaker.config.config_utils import (
4242
_log_sagemaker_config_single_substitution,
4343
_log_sagemaker_config_merge,
44+
get_sagemaker_config_logger,
4445
)
4546
from sagemaker.session_settings import SessionSettings
4647
from sagemaker.workflow import is_pipeline_variable, is_pipeline_parameter_string
@@ -1099,11 +1100,13 @@ def get_sagemaker_config_value(sagemaker_session, key):
10991100
return None
11001101

11011102
if (
1102-
sagemaker_session is not None
1103-
and sagemaker_session.settings is not None
1103+
sagemaker_session.settings is not None
11041104
and sagemaker_session.settings.ignore_sagemaker_config
11051105
):
1106-
logger.info("Ignoring defaults config.")
1106+
get_sagemaker_config_logger().info(
1107+
"Ignoring defaults config because "
1108+
"`ignore_sagemaker_config` was set in Session settings."
1109+
)
11071110
return None
11081111

11091112
if sagemaker_session.sagemaker_config:

tests/unit/test_utils.py

+14-4
Original file line numberDiff line numberDiff line change
@@ -1177,8 +1177,14 @@ def test_retry_with_backoff(patched_sleep):
11771177
assert retry_with_backoff(callable_func, 2) == func_return_val
11781178

11791179

1180-
@patch("sagemaker.utils.logger.info")
1181-
def test_resolve_value_from_config(mock_info_logger):
1180+
@patch("sagemaker.utils.get_sagemaker_config_logger")
1181+
def test_resolve_value_from_config(mock_get_sagemaker_config_logger):
1182+
1183+
mock_config_logger = Mock()
1184+
mock_get_sagemaker_config_logger.return_value = mock_config_logger
1185+
1186+
mock_info_logger = Mock()
1187+
mock_config_logger.info = mock_info_logger
11821188
# using a shorter name for inside the test
11831189
sagemaker_session = MagicMock()
11841190
sagemaker_session.settings.ignore_sagemaker_config = False
@@ -1235,12 +1241,16 @@ def test_resolve_value_from_config(mock_info_logger):
12351241

12361242
sagemaker_session.settings.ignore_sagemaker_config = True
12371243
assert resolve_value_from_config("blah", config_key_path, None, sagemaker_session) == "blah"
1238-
mock_info_logger.assert_called_once_with("Ignoring defaults config.")
1244+
mock_info_logger.assert_called_once_with(
1245+
"Ignoring defaults config because `ignore_sagemaker_config` was set in Session settings."
1246+
)
12391247

12401248
mock_info_logger.reset_mock()
12411249

12421250
assert resolve_value_from_config(None, config_key_path, "blah", sagemaker_session) == "blah"
1243-
mock_info_logger.assert_called_once_with("Ignoring defaults config.")
1251+
mock_info_logger.assert_called_once_with(
1252+
"Ignoring defaults config because `ignore_sagemaker_config` was set in Session settings."
1253+
)
12441254

12451255

12461256
@patch("jsonschema.validate")

0 commit comments

Comments
 (0)