Skip to content

Commit 7cd5c6f

Browse files
author
Andre Moeller
committed
pr updates
1 parent 938d4e1 commit 7cd5c6f

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/sagemaker/session.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -751,7 +751,7 @@ def expand_role(self, role):
751751
def get_caller_identity_arn(self):
752752
"""Returns the ARN user or role whose credentials are used to call the API.
753753
Returns:
754-
(str): The ARN uer or role
754+
(str): The ARN user or role
755755
"""
756756
assumed_role = self.boto_session.client('sts').get_caller_identity()['Arn']
757757

@@ -766,7 +766,8 @@ def get_caller_identity_arn(self):
766766
try:
767767
role = self.boto_session.client('iam').get_role(RoleName=role_name)['Role']['Arn']
768768
except ClientError:
769-
LOGGER.warning("Couldn't call 'get_role' to get Role ARN from role name {}.".format(role_name))
769+
LOGGER.warning("Couldn't call 'get_role' to get Role ARN from role name {} to get Role path."
770+
.format(role_name))
770771

771772
return role
772773

tests/unit/test_session.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,17 @@ def test_get_caller_identity_arn_from_an_user(boto_session):
6969
assert actual == 'arn:aws:iam::369233609183:user/mia'
7070

7171

72-
def test_get_caller_identity_arn_from_an_user_without_permissions(boto_session):
72+
@patch('logging.Logger.warning')
73+
def test_get_caller_identity_arn_from_an_user_without_permissions(boto_session, mock_logger):
7374
sess = Session(boto_session)
7475
arn = 'arn:aws:iam::369233609183:user/mia'
7576
sess.boto_session.client('sts').get_caller_identity.return_value = {'Arn': arn}
7677
sess.boto_session.client('iam').get_role.side_effect = ClientError('Bad permissions!', {})
7778

79+
7880
actual = sess.get_caller_identity_arn()
7981
assert actual == 'arn:aws:iam::369233609183:user/mia'
82+
mock_logger.assert_called_once()
8083

8184

8285
def test_get_caller_identity_arn_from_a_role(boto_session):

0 commit comments

Comments
 (0)