Skip to content

Commit 7154fc6

Browse files
committed
chore: improve comments
1 parent 0262cdc commit 7154fc6

File tree

4 files changed

+10
-0
lines changed

4 files changed

+10
-0
lines changed

src/sagemaker/jumpstart/estimator.py

+3
Original file line numberDiff line numberDiff line change
@@ -489,6 +489,9 @@ def __init__(
489489
private Docker registry where your training image is hosted (Default: None).
490490
When it's set to None, SageMaker will not do authentication before pulling the image
491491
in the private Docker registry. (Default: None).
492+
493+
Raises:
494+
ValueError: If the model ID is not recognized by JumpStart.
492495
"""
493496

494497
if not is_valid_model_id(

src/sagemaker/jumpstart/model.py

+3
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,9 @@ def __init__(
254254
the SageMaker Python SDK attempts to use either the CodeCommit
255255
credential helper or local credential storage for authentication.
256256
(Default: None).
257+
258+
Raises:
259+
ValueError: If the model ID is not recognized by JumpStart.
257260
"""
258261

259262
if not is_valid_model_id(

tests/integ/sagemaker/jumpstart/estimator/test_jumpstart_estimator.py

+2
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,15 @@ def test_jumpstart_estimator(setup):
4343
max_run=259200, # avoid exceeding resource limits
4444
)
4545

46+
# uses ml.p3.2xlarge instance
4647
estimator.fit(
4748
{
4849
"training": f"s3://{get_jumpstart_content_bucket(JUMPSTART_DEFAULT_REGION_NAME)}/"
4950
f"{get_training_dataset_for_model_and_version(model_id, model_version)}",
5051
}
5152
)
5253

54+
# uses ml.p3.2xlarge instance
5355
predictor = estimator.deploy(
5456
tags=[{"Key": JUMPSTART_TAG, "Value": os.environ[ENV_VAR_JUMPSTART_SDK_TEST_SUITE_ID]}],
5557
role=get_sm_session().get_caller_identity_arn(),

tests/integ/sagemaker/jumpstart/model/test_jumpstart_model.py

+2
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ def test_non_prepacked_jumpstart_model(setup):
4040
sagemaker_session=get_sm_session(),
4141
)
4242

43+
# uses ml.m5.4xlarge instance
4344
predictor = model.deploy(
4445
tags=[{"Key": JUMPSTART_TAG, "Value": os.environ[ENV_VAR_JUMPSTART_SDK_TEST_SUITE_ID]}],
4546
)
@@ -62,6 +63,7 @@ def test_prepacked_jumpstart_model(setup):
6263
sagemaker_session=get_sm_session(),
6364
)
6465

66+
# uses ml.p3.2xlarge instance
6567
predictor = model.deploy(
6668
tags=[{"Key": JUMPSTART_TAG, "Value": os.environ[ENV_VAR_JUMPSTART_SDK_TEST_SUITE_ID]}],
6769
)

0 commit comments

Comments
 (0)