Skip to content

Commit 70c95b6

Browse files
authored
change: remove TODO comment on import-error Pylint check (#918)
By running Pylint before any of the unit tests (and dependency installs), the import-error check will always fail since the dependencies are not yet installed. We could move Pylint to a later stage to resolve this, but there's value in this quick check occurring before the unit tests. As a result, this Pylint check is being disabled.
1 parent 2d7bff8 commit 70c95b6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.pylintrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ disable=
8383
too-many-instance-attributes,
8484
line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
8585
len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
86-
import-error, # TODO: Fix import errors
86+
import-error, # Since we run Pylint before any of our builds in tox, this will always fail
8787
attribute-defined-outside-init, # TODO: Fix scope
8888
protected-access, # TODO: Fix access
8989
abstract-method, # TODO: Fix abstract methods

0 commit comments

Comments
 (0)