You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
change: remove TODO comment on import-error Pylint check (#918)
By running Pylint before any of the unit tests (and dependency
installs), the import-error check will always fail since the
dependencies are not yet installed.
We could move Pylint to a later stage to resolve this, but there's
value in this quick check occurring before the unit tests.
As a result, this Pylint check is being disabled.
Copy file name to clipboardExpand all lines: .pylintrc
+1-1
Original file line number
Diff line number
Diff line change
@@ -83,7 +83,7 @@ disable=
83
83
too-many-instance-attributes,
84
84
line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
85
85
len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
86
-
import-error, #TODO: Fix import errors
86
+
import-error, #Since we run Pylint before any of our builds in tox, this will always fail
0 commit comments