Skip to content

Commit 688186b

Browse files
committed
Update model
1 parent 90ae56c commit 688186b

File tree

2 files changed

+4
-32
lines changed

2 files changed

+4
-32
lines changed

src/sagemaker/serve/builder/transformers_builder.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def _create_transformers_model(self) -> Type[Model]:
9494
)
9595
hf_config = image_uris.config_for_framework("huggingface").get("inference")
9696
config = hf_config["versions"]
97-
base_hf_version = sorted(config.keys(), key=lambda v: Version(v))[0]
97+
base_hf_version = sorted(config.keys(), key=lambda v: Version(v), reverse=True)[0]
9898

9999
if hf_model_md is None:
100100
raise ValueError("Could not fetch HF metadata")
@@ -269,7 +269,7 @@ def _get_supported_version(self, hf_config, hugging_face_version, base_fw):
269269
if len(hugging_face_version.split(".")) == 2:
270270
base_fw_version = ".".join(base_fw_version.split(".")[:-1])
271271
versions_to_return.append(base_fw_version)
272-
return sorted(versions_to_return)[0]
272+
return sorted(versions_to_return, reverse=True)[0]
273273

274274
def _build_for_transformers(self):
275275
"""Method that triggers model build

tests/integ/sagemaker/serve/test_schema_builder.py

+2-30
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,9 @@ def test_model_builder_happy_path_with_task_provided_remote_schema_mode(
208208
)
209209
@pytest.mark.parametrize(
210210
"model_id, task_provided, instance_type_provided",
211-
[("openai/whisper-large-v3", "automatic-speech-recognition", "ml.m5.xlarge")],
211+
[("openai/whisper-tiny.en", "automatic-speech-recognition", "ml.m5.4xlarge")],
212212
)
213-
def test_model_builder_happy_path_with_task_provided_remote_schema_mode_asr(
213+
def test_model_builder_with_task_provided_remote_schema_mode_asr(
214214
model_id, task_provided, sagemaker_session, instance_type_provided
215215
):
216216
model_builder = ModelBuilder(
@@ -228,34 +228,6 @@ def test_model_builder_happy_path_with_task_provided_remote_schema_mode_asr(
228228
assert model_builder.schema_builder.sample_input == inputs
229229
assert model_builder.schema_builder.sample_output == outputs
230230

231-
with timeout(minutes=SERVE_SAGEMAKER_ENDPOINT_TIMEOUT):
232-
caught_ex = None
233-
try:
234-
iam_client = sagemaker_session.boto_session.client("iam")
235-
role_arn = iam_client.get_role(RoleName="SageMakerRole")["Role"]["Arn"]
236-
237-
logger.info("Deploying and predicting in SAGEMAKER_ENDPOINT mode...")
238-
predictor = model.deploy(
239-
role=role_arn, instance_count=1, instance_type=instance_type_provided
240-
)
241-
242-
predicted_outputs = predictor.predict(inputs)
243-
assert predicted_outputs is not None
244-
245-
except Exception as e:
246-
caught_ex = e
247-
finally:
248-
cleanup_model_resources(
249-
sagemaker_session=model_builder.sagemaker_session,
250-
model_name=model.name,
251-
endpoint_name=model.endpoint_name,
252-
)
253-
if caught_ex:
254-
logger.exception(caught_ex)
255-
assert (
256-
False
257-
), f"{caught_ex} was thrown when running transformers sagemaker endpoint test"
258-
259231

260232
def test_model_builder_negative_path_with_invalid_task(sagemaker_session):
261233
model_builder = ModelBuilder(

0 commit comments

Comments
 (0)