chore: address PR comments

Author: evakravi

src/sagemaker/jumpstart/exceptions.py

@@ -81,15 +81,15 @@ def __init__(
                 self.message = (
                     f"Version '{version}' of JumpStart model '{model_id}' "  # type: ignore
                     "has at least 1 vulnerable dependency in the inference script. "
-                    "Please try targetting a higher version of the model or using a "
+                    "Please try targeting a higher version of the model or using a "
                     "different model. List of vulnerabilities: "
                     f"{', '.join(vulnerabilities)}"  # type: ignore
                 )
             elif scope == JumpStartScriptScope.TRAINING:
                 self.message = (
                     f"Version '{version}' of JumpStart model '{model_id}' "  # type: ignore
                     "has at least 1 vulnerable dependency in the training script. "
-                    "Please try targetting a higher version of the model or using a "
+                    "Please try targeting a higher version of the model or using a "
                     "different model. List of vulnerabilities: "
                     f"{', '.join(vulnerabilities)}"  # type: ignore
                 )
@@ -125,7 +125,7 @@ def __init__(
                 raise RuntimeError("Must specify `model_id` and `version` arguments.")
             self.message = (
                 f"Version '{version}' of JumpStart model '{model_id}' is deprecated. "
-                "Please try targetting a higher version of the model or using a "
+                "Please try targeting a higher version of the model or using a "
                 "different model."
             )
 

src/sagemaker/jumpstart/utils.py

@@ -542,7 +542,11 @@ def is_valid_model_id(
     model_version: Optional[str] = None,
     script: enums.JumpStartScriptScope = enums.JumpStartScriptScope.INFERENCE,
 ) -> bool:
-    """Returns True if the model ID is supported for the given script."""
+    """Returns True if the model ID is supported for the given script.
+
+    Raises:
+        ValueError: If the script is not supported by JumpStart.
+    """
     if model_id in {None, ""}:
         return False
     if not isinstance(model_id, str):

tests/unit/sagemaker/jumpstart/estimator/test_estimator.py

@@ -354,7 +354,7 @@ def test_estimator_use_kwargs(self):
             "inputs": {"hello": "world"},
             "wait": True,
             "logs": "All",
-            "job_name": "none of your business",
+            "job_name": "none_of_your_business",
             "experiment_config": {"1": "2"},
         }
         all_deploy_kwargs_used = {
@@ -476,7 +476,7 @@ def evaluate_estimator_workflow_with_kwargs(
         }
 
         expected_fit_kwargs = overwrite_dictionary(
-            {"inputs": channels, "wait": True, "job_name": "none of your business"}, fit_kwargs
+            {"inputs": channels, "wait": True, "job_name": "none_of_your_business"}, fit_kwargs
         )
 
         estimator.fit(**expected_fit_kwargs)

tests/unit/sagemaker/jumpstart/test_utils.py

@@ -788,7 +788,7 @@ def make_vulnerable_inference_spec(*largs, **kwargs):
     assert (
         "Version '*' of JumpStart model 'pytorch-eqa-bert-base-cased' has at least 1 "
         "vulnerable dependency in the inference script. "
-        "Please try targetting a higher version of the model or using a different model. "
+        "Please try targeting a higher version of the model or using a different model. "
         "List of vulnerabilities: some, vulnerability"
     ) == str(e.value.message)
 
@@ -827,7 +827,7 @@ def make_vulnerable_training_spec(*largs, **kwargs):
     assert (
         "Version '*' of JumpStart model 'pytorch-eqa-bert-base-cased' has at least 1 "
         "vulnerable dependency in the training script. "
-        "Please try targetting a higher version of the model or using a different model. "
+        "Please try targeting a higher version of the model or using a different model. "
         "List of vulnerabilities: some, vulnerability"
     ) == str(e.value.message)
 
@@ -866,7 +866,7 @@ def make_deprecated_spec(*largs, **kwargs):
             region="us-west-2",
         )
     assert "Version '*' of JumpStart model 'pytorch-eqa-bert-base-cased' is deprecated. "
-    "Please try targetting a higher version of the model or using a different model." == str(
+    "Please try targeting a higher version of the model or using a different model." == str(
         e.value.message
     )